[lldb] add has methods to all DemangledNameInfo attributes

[charles-zablit]

Add hasX methods to all the attributes of DemangledNameInfo.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Charles Zablit (charles-zablit)

Changes

Add hasX methods to all the attributes of DemangledNameInfo.

---

Full diff: https://github.com/llvm/llvm-project/pull/144549.diff

1 Files Affected:

• (modified) lldb/include/lldb/Core/DemangledNameInfo.h (+19)

diff --git a/lldb/include/lldb/Core/DemangledNameInfo.h b/lldb/include/lldb/Core/DemangledNameInfo.h
index 4b5ba5e42b3b1..a2f3fde90c611 100644
--- a/lldb/include/lldb/Core/DemangledNameInfo.h
+++ b/lldb/include/lldb/Core/DemangledNameInfo.h
@@ -73,6 +73,25 @@ struct DemangledNameInfo {
   bool hasBasename() const {
     return BasenameRange.second > BasenameRange.first;
   }
+
+  /// Returns \c true if this object holds a valid scope range.
+  bool hasScope() const { return ScopeRange.second > ScopeRange.first; }
+
+  /// Returns \c true if this object holds a valid arguments range.
+  bool hasArguments() const {
+    return ArgumentsRange.second > ArgumentsRange.first;
+  }
+
+  /// Returns \c true if this object holds a valid qualifiers range.
+  bool hasQualifiers() const {
+    return QualifiersRange.second > QualifiersRange.first;
+  }
+
+  /// Returns \c true if this object holds a valid prefix range.
+  bool hasPrefix() const { return PrefixRange.second > PrefixRange.first; }
+
+  /// Returns \c true if this object holds a valid suffix range.
+  bool hasSuffix() const { return SuffixRange.second > SuffixRange.first; }
 };
 
 /// An OutputBuffer which keeps a record of where certain parts of a

[charles-zablit]

Rationale: I am working on a patch (swiftlang#10710) which adds the hasArguments method and I think it would be a good fit for upstream llvm as well.

[adrian-prantl]

It would be nice if these were at least unit-tested on llvm.org, but given how trivial the implementation is, make not strictly necessary.

[Michael137]

Agreed, if we can somehow call these in MangledTest.cpp, that'd be great

Possibly just adding another unit-test case that demangles a simple mangled name and confirms that these getters return true/false appropriately

[charles-zablit]

I ended up creating a new test suite, to isolate the checks as much as possible. This way, if someone accidentally refactors one of the has methods and replaces basenameRange with scopeRange in hasBasename, we are sure to catch it.

[Michael137]

Nice, that's what i had in mind. Thanks!