Skip to content

[libc][math] Fix range and comments in exhaustive hypotf_test #131769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2025
Merged

[libc][math] Fix range and comments in exhaustive hypotf_test #131769

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1f6da0
Fix STOP limit for x in exhaustive hypotf_test
meltq Mar 18, 2025
241ca8e
Fix comments
meltq Mar 24, 2025
cae4d48
Changed to 2^24
meltq Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libc/test/src/math/exhaustive/hypotf_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ struct HypotfChecker : public virtual LIBC_NAMESPACE::testing::Test {
using StorageType = typename FPBits::StorageType;

uint64_t check(uint32_t start, uint32_t stop, mpfr::RoundingMode rounding) {
// Range of the second input: [2^37, 2^48).
// Range of the second input: [2^37, 2^48].
constexpr uint32_t Y_START = (37U + 127U) << 23;
constexpr uint32_t Y_STOP = (48U + 127U) << 23;

Expand Down Expand Up @@ -51,9 +51,9 @@ struct HypotfChecker : public virtual LIBC_NAMESPACE::testing::Test {

using LlvmLibcHypotfExhaustiveTest = LlvmLibcExhaustiveMathTest<HypotfChecker>;

// Range of the first input: [2^23, 2^24);
// Range of the first input: [2^23, 2^24];
static constexpr uint32_t START = (23U + 127U) << 23;
static constexpr uint32_t STOP = ((23U + 127U) << 23) + 1;
static constexpr uint32_t STOP = (24U + 127U) << 23;

TEST_F(LlvmLibcHypotfExhaustiveTest, PositiveRange) {
test_full_range_all_roundings(START, STOP);
Expand Down
Loading