[flang-rt] Fixed HAVE_LDBL_MANT_DIG_113 detection. #131010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought I guessed a fix in llvm#130836, but I was wrong. We actually had the same code in `flang/cmake/modules/FlangCommon.cmake`. The check does not pass in flang-rt bootstrap build, because `-nostdinc++` is added for all `runtimes` checks. I decided to make the check with the C header, though, I am still unsure whether it is reliable with a clang that has not been installed (it is taken from the build structure during flang-rt configure step). I verified that this PR enables REAL(16) math entries on aarch64.
klausler
approved these changes
Mar 12, 2025
frederik-h
pushed a commit
to frederik-h/llvm-project
that referenced
this pull request
Mar 18, 2025
I thought I guessed a fix in llvm#130836, but I was wrong. We actually had the same code in `flang/cmake/modules/FlangCommon.cmake`. The check does not pass in flang-rt bootstrap build, because `-nostdinc++` is added for all `runtimes` checks. I decided to make the check with the C header, though, I am still unsure whether it is reliable with a clang that has not been installed (it is taken from the build structure during flang-rt configure step). I verified that this PR enables REAL(16) math entries on aarch64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I guessed a fix in #130836, but I was wrong.
We actually had the same code in
flang/cmake/modules/FlangCommon.cmake.The check does not pass in flang-rt bootstrap build, because
-nostdinc++is added for allruntimeschecks.I decided to make the check with the C header, though, I am still
unsure whether it is reliable with a clang that has not been
installed (it is taken from the build structure during flang-rt
configure step).
I verified that this PR enables REAL(16) math entries on aarch64.