[mlir][tosa] Update the description section for CastOp to align with TOSA v1.0 spec #129958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-tosa Author: Jerry-Ge (Jerry-Ge) ChangesUpdated the description section to include all data types and match the ordering with the spec. https://www.mlplatform.org/tosa/tosa_spec.html#_cast Full diff: https://github.com/llvm/llvm-project/pull/129958.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
index ff83e4072b6c0..d84191f697341 100644
--- a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
+++ b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
@@ -2238,24 +2238,52 @@ def Tosa_CastOp: Tosa_Op<"cast", [Pure,
| Mode | Input | Output |
|--------------------------|---------|---------|
- | signed 8 to bool | int8 | Boolean |
- | signed 16 to bool | int16 | Boolean |
- | signed 32 to bool | int32 | Boolean |
- | bool to 8 | Boolean | int8 |
- | bool to 16 | Boolean | int16 |
- | bool to 32 | Boolean | int32 |
- | signed 8 to signed 16 | int8 | int16 |
- | signed 8 to signed 32 | int8 | int32 |
- | signed 16 to signed 8 | int16 | int8 |
- | signed 16 to signed 32 | int16 | int32 |
- | signed 32 to signed 8 | int32 | int8 |
- | signed 32 to signed 16 | int32 | int16 |
- | float to signed 8 | float | int8 |
- | float to signed 16 | float | int16 |
- | signed 8 to float | int8 | float |
- | signed 16 to float | int16 | float |
- | float 32 to float 64 | float32 | float64 |
- | float 64 to float 32 | float64 | float32 |
+ | fp16 to fp32 | float16 | float32 |
+ | fp16 to int 16 | float16 | int16 |
+ | fp16 to int 32 | float16 | int32 |
+ | fp16 to int 8 | float16 | int8 |
+ | fp32 to fp16 | float32 | float16 |
+ | fp32 to int 16 | float32 | int16 |
+ | fp32 to int 32 | float32 | int32 |
+ | fp32 to int 8 | float32 | int8 |
+ | int 16 to fp16 | int16 | float16 |
+ | int 16 to fp32 | int16 | float32 |
+ | int 32 to fp16 | int32 | float16 |
+ | int 32 to fp32 | int32 | float32 |
+ | int 8 to fp16 | int8 | float16 |
+ | int 8 to fp32 | int8 | float32 |
+ | bool to int 16 | Boolean | int16 |
+ | bool to int 32 | Boolean | int32 |
+ | bool to int 8 | Boolean | int8 |
+ | int 16 to bool | int16 | Boolean |
+ | int 16 to int 32 | int16 | int32 |
+ | int 16 to int 8 | int16 | int8 |
+ | int 32 to bool | int32 | Boolean |
+ | int 32 to int 16 | int32 | int16 |
+ | int 32 to int 8 | int32 | int8 |
+ | int 8 to bool | int8 | Boolean |
+ | int 8 to int 16 | int8 | int16 |
+ | int 8 to int 32 | int8 | int32 |
+ | bf16 to fp32 | bf16 | float32 |
+ | bf16 to int 16 | bf16 | int16 |
+ | bf16 to int 32 | bf16 | int32 |
+ | bf16 to int 8 | bf16 | int8 |
+ | fp32 to bf16 | float32 | bf16 |
+ | int 16 to bf16 | int16 | bf16 |
+ | int 32 to bf16 | int32 | bf16 |
+ | int 8 to bf16 | int8 | bf16 |
+ | bf16 to fp8e4m3 | bf16 | fp8e4m3 |
+ | fp8e4m3 to bf16 | fp8e4m3 | bf16 |
+ | bf16 to fp8e5m2 | bf16 | fp8e5m2 |
+ | fp8e5m2 to bf16 | fp8e5m2 | bf16 |
+ | fp16 to fp8e4m3 | float16 | fp8e4m3 |
+ | fp32 to fp8e4m3 | float32 | fp8e4m3 |
+ | fp8e4m3 to fp16 | fp8e4m3 | float16 |
+ | fp8e4m3 to fp32 | fp8e4m3 | float32 |
+ | fp16 to fp8e5m2 | float16 | fp8e5m2 |
+ | fp32 to fp8e5m2 | float32 | fp8e5m2 |
+ | fp8e5m2 to fp16 | fp8e5m2 | float16 |
+ | fp8e5m2 to fp32 | fp8e5m2 | float32 |
}];
let arguments = (ins
|
GeorgeARM
approved these changes
Mar 6, 2025
agree. Could i get more code review there or approval for #127730? Thanks! @GeorgeARM @lhutton1 |
…TOSA v1.0 spec Updated the description section to include all data types and match the ordering with the spec. Signed-off-by: Jerry Ge <[email protected]> Change-Id: I3075a3599f2e2732c7796a640697c75e3d17547f
jph-13
pushed a commit
to jph-13/llvm-project
that referenced
this pull request
Mar 21, 2025
…TOSA v1.0 spec (llvm#129958) Updated the description section to include all data types and match the ordering with the spec. https://www.mlplatform.org/tosa/tosa_spec.html#_cast Signed-off-by: Jerry Ge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the description section to include all data types and match the ordering with the spec.
https://www.mlplatform.org/tosa/tosa_spec.html#_cast