-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[libcxx] Export directory_iterator in module build #129195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is workaround for the link error like https://crbug.com/390537876.
@llvm/pr-subscribers-libcxx Author: Takuto Ikuta (atetubou) ChangesThis is workaround for the link error like https://crbug.com/390537876. Might be related to #120108 too. Full diff: https://github.com/llvm/llvm-project/pull/129195.diff 1 Files Affected:
diff --git a/libcxx/include/module.modulemap b/libcxx/include/module.modulemap
index 0f2016e7f5d15..f94b6fc519399 100644
--- a/libcxx/include/module.modulemap
+++ b/libcxx/include/module.modulemap
@@ -1229,7 +1229,11 @@ module std [system] {
module filesystem {
module copy_options { header "__filesystem/copy_options.h" }
module directory_entry { header "__filesystem/directory_entry.h" }
- module directory_iterator { header "__filesystem/directory_iterator.h" }
+ module directory_iterator {
+ header "__filesystem/directory_iterator.h"
+ // This is a workaround for https://github.com/llvm/llvm-project/issues/120108.
+ export *
+ }
module directory_options { header "__filesystem/directory_options.h" }
module file_status { header "__filesystem/file_status.h" }
module file_time_type { header "__filesystem/file_time_type.h" }
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for review, can I ask you to merge this? |
Thanks for patch! I've just landed it. |
This is workaround for the link error like https://crbug.com/390537876. Might be related to llvm#120108 too.
This is workaround for the link error like https://crbug.com/390537876.
Might be related to #120108 too.