Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[VP][RISCV] Add a vp.load.ff intrinsic for fault only first load. #128593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[VP][RISCV] Add a vp.load.ff intrinsic for fault only first load. #128593
Changes from all commits
b4e4666
07cf13c
2fb476e
4f2fbff
93d6ab7
5f0f3cc
6720314
3a8289f
081ab46
c1fae0d
c6c237d
1b39f42
cbf0bb0
249b585
7e6a57e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to ask why this doesn't have an offset operand like the others so it could inherit from
VPBaseLoadStoreSDNode
, but then I realised we don't use the offset in RISCVISelLowering for regular vp.load/store.SelectionDAGBuilder doesn't set it, I think it's always undef. Not for this PR but can we remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can probably remove Offset and Addressing mode until a target comes along that needs them.