-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[libc] added btowc to wchar.h generated header #124168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-libc Author: Alex Prabhat Bara (alexprabhat99) ChangesFixes: #124152 Full diff: https://github.com/llvm/llvm-project/pull/124168.diff 1 Files Affected:
diff --git a/libc/include/wchar.yaml b/libc/include/wchar.yaml
index 27a5926b574554..159237c7b4ff7c 100644
--- a/libc/include/wchar.yaml
+++ b/libc/include/wchar.yaml
@@ -15,3 +15,9 @@ functions:
return_type: int
arguments:
- type: wint_t
+ - name: btowc
+ standards:
+ - stdc
+ return_type: wint_t
+ arguments:
+ - type: int
|
|
Do you mind disabling the hiding of your email address, as per the bot's comment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (besides the point from the bot). Need me to merge this for you?
I have turned off Keep my email addresses private setting in my account. |
Yes, please @nickdesaulniers . |
Thanks. Do you mind rebasing+force pushing? I think that should update your email address on your commit. Otherwise, you can do |
LGTM; thanks! Side note: I noticed you're working out of a branch named |
Thanks! I appreciate the feedback. I'll make sure to use feature branches moving forward. |
Fixes: #124152