Skip to content

[libc] added btowc to wchar.h generated header #124168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

alexprabhat99
Copy link
Contributor

Fixes: #124152

@llvmbot llvmbot added the libc label Jan 23, 2025
@llvmbot
Copy link
Member

llvmbot commented Jan 23, 2025

@llvm/pr-subscribers-libc

Author: Alex Prabhat Bara (alexprabhat99)

Changes

Fixes: #124152


Full diff: https://github.com/llvm/llvm-project/pull/124168.diff

1 Files Affected:

  • (modified) libc/include/wchar.yaml (+6)
diff --git a/libc/include/wchar.yaml b/libc/include/wchar.yaml
index 27a5926b574554..159237c7b4ff7c 100644
--- a/libc/include/wchar.yaml
+++ b/libc/include/wchar.yaml
@@ -15,3 +15,9 @@ functions:
     return_type: int
     arguments:
       - type: wint_t
+  - name: btowc
+    standards:
+      - stdc
+    return_type: wint_t
+    arguments:
+      - type: int

Copy link

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

@nickdesaulniers nickdesaulniers self-requested a review January 23, 2025 18:38
@nickdesaulniers
Copy link
Member

Do you mind disabling the hiding of your email address, as per the bot's comment?
#124168 (comment)

Copy link
Member

@nickdesaulniers nickdesaulniers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (besides the point from the bot). Need me to merge this for you?

@alexprabhat99
Copy link
Contributor Author

Do you mind disabling the hiding of your email address, as per the bot's comment? #124168 (comment)

I have turned off Keep my email addresses private setting in my account.

@alexprabhat99
Copy link
Contributor Author

LGTM (besides the point from the bot). Need me to merge this for you?

Yes, please @nickdesaulniers .
Thank you.

@nickdesaulniers
Copy link
Member

Do you mind disabling the hiding of your email address, as per the bot's comment? #124168 (comment)

I have turned off Keep my email addresses private setting in my account.

Thanks. Do you mind rebasing+force pushing? I think that should update your email address on your commit. Otherwise, you can do git commit --amend --author="First Last <email>" the force push.

@nickdesaulniers
Copy link
Member

LGTM; thanks!

Side note: I noticed you're working out of a branch named main. I highly recommend doing feature development in new branches. git checkout -b <new branch name>. Then if you want to abandon that work, you can just git checkout main. Branches are cheap to create.

@nickdesaulniers nickdesaulniers merged commit cb981cc into llvm:main Jan 23, 2025
9 of 10 checks passed
@alexprabhat99
Copy link
Contributor Author

Thanks! I appreciate the feedback. I'll make sure to use feature branches moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libc] add btowc to wchar.h generated header
3 participants