-
Notifications
You must be signed in to change notification settings - Fork 13.7k
[libcxx] Use _ftelli64/_fseeki64 on Windows #123128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2739c3c
[libcxx] Use _ftelli64/_fseeki64 on Windows
mstorsjo 9b9f6c5
Factorize repeated fseek/ftell calls
mstorsjo 26a0e91
Fix formatting
mstorsjo a7e48af
Hide the new symbols from the ABI
mstorsjo b4be3ef
Remove the intermediate _LIBCPP_HAS_OFF_T_FUNCTIONS define
mstorsjo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just make these free functions. (I'd just define them at the top of the file). It would also be good to remove the
!defined(_LIBCPP_MSVCRT)
from the definition of_LIBCPP_HAS_OFF_T_FUNCTIONS
and probably just inline_LIBCPP_HAS_OFF_T_FUNCTIONS
as a whole, since at that point it's just equivalent dodefind(_NEWLIB_VERSION)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the functions in the class, as they use
pos_type
, but I updated the PR to remove the unnecessary intermediate define_LIBCPP_HAS_OFF_T_FUNCTIONS
.