Skip to content

llvm-cov: Merge records for template instantiations #121197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 79 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
79 commits
Select commit Hold shift + click to select a range
178b57c
[Coverage] Move SingleByteCoverage out of CountedRegion
chapuni Oct 2, 2024
aacb50d
[Coverage] Make SingleByteCoverage work consistent to merging
chapuni Oct 2, 2024
b9bbc7c
Rework. (Also reverts "[Coverage] Move SingleByteCoverage out of Cou…
chapuni Oct 5, 2024
52f072e
clang/test/CoverageMapping/single-byte-counters.cpp: Rewrite counter …
chapuni Oct 17, 2024
97a4a8f
test/llvm-cov: Transform %.c* tests to {%.test, Inputs/%.c*}
chapuni Nov 20, 2024
c50c492
Introduce test/llvm-cov/Inputs/yaml.makefile for convenience.
chapuni Nov 20, 2024
d7c5b44
Add tests for SingleByteCoverage
chapuni Nov 20, 2024
6675226
Merge branch 'users/chapuni/cov/single/test' into users/chapuni/cov/s…
chapuni Nov 20, 2024
5fc3408
Fix a test to fix linecount=1
chapuni Nov 20, 2024
eb7fff9
threads.c: Fixup on the clean testdir
chapuni Nov 20, 2024
7543095
Rename threads.c to threads.test since it is no longer C source file.
chapuni Nov 21, 2024
00ac90d
llvm/test/tools/llvm-cov/Inputs: Avoid wildcards `rm -rf %t*.dir`
chapuni Nov 21, 2024
fcb3ee8
Merge branch 'main' into users/chapuni/cov/single/test
chapuni Dec 21, 2024
5fa862a
Use `[[#min(C,n)]]` for tests
chapuni Dec 21, 2024
805e9a9
llvm-cov: Introduce `--binary-counters`
chapuni Dec 21, 2024
5b6c0b0
LLVMCoverage: Unify getCoverageForFile and getCoverageForFunction
chapuni Dec 21, 2024
68d7b3b
Merge branch 'users/chapuni/cov/single/test' into users/chapuni/cov/s…
chapuni Dec 21, 2024
24457a7
Update tests
chapuni Dec 21, 2024
805dbd9
Merge branches 'users/chapuni/cov/single/merge' and 'users/chapuni/co…
chapuni Dec 21, 2024
f96b435
New SingleByteCoverage
chapuni Dec 21, 2024
47550d1
threads.c => threads.test (following #113114)
chapuni Dec 22, 2024
f4dc4eb
s/Count1/BinaryCount/
chapuni Dec 23, 2024
822620b
Update desc
chapuni Dec 23, 2024
9a20404
Merge branch 'main' into users/chapuni/cov/single/merge
chapuni Dec 23, 2024
658bd48
Merge branch 'main' into users/chapuni/cov/binary
chapuni Dec 24, 2024
0780993
Merge branch 'users/chapuni/cov/binary' into users/chapuni/cov/single…
chapuni Dec 24, 2024
dfc99ba
Fix wrong merge resolutions
chapuni Dec 24, 2024
f3c9593
Reorganize CoverageMapping::SingleByteCoverage
chapuni Dec 24, 2024
3780e07
Prune commented-out line
chapuni Dec 24, 2024
36b4aaf
[Coverage] Make `MCDCRecord::Folded` as `[false/true]` with BitVector…
chapuni Dec 27, 2024
978070d
[Coverage] MCDC: Move `findIndependencePairs` into `MCDCRecord`
chapuni Dec 27, 2024
f42bb83
Merge branches 'users/chapuni/cov/merge/mcdcfold' and 'users/chapuni/…
chapuni Dec 27, 2024
3abe2ac
[Coverage] Sort `MCDCRecord::ExecVectors` order by Bitmap index
chapuni Dec 27, 2024
f86c537
llvm-cov: Refactor CoverageSummaryInfo. NFC.
chapuni Dec 27, 2024
92bf1c1
llvm-cov: Emit RegionCoverage based on `CoverageData::Segments`
chapuni Dec 27, 2024
2293b8d
Merge remote-tracking branches 'origin/users/chapuni/cov/single/refac…
chapuni Dec 27, 2024
35b2948
Merge branches 'users/chapuni/cov/merge/mov_ind' and 'users/chapuni/c…
chapuni Dec 27, 2024
c1678ea
llvm-cov: Use `getCoverageForFile()`
chapuni Dec 27, 2024
273eea7
llvm-cov: Introduce `--merge-instantiations=<MergeStrategy>`
chapuni Dec 27, 2024
2330477
Merge branches 'users/chapuni/cov/merge/strategy' and 'users/chapuni/…
chapuni Dec 27, 2024
dc0ef8f
llvm-cov: [MCDC] Merge and recalculate independence pairs on template…
chapuni Dec 27, 2024
894c383
Merge branch 'main' into users/chapuni/cov/single/refactor
chapuni Dec 27, 2024
7c26a2a
Merge branch 'main' into users/chapuni/cov/single/refactor
chapuni Dec 27, 2024
184dc0c
Merge branch 'users/chapuni/cov/single/refactor' into users/chapuni/c…
chapuni Dec 27, 2024
8536495
Merge branch 'users/chapuni/cov/single/refactor' into users/chapuni/c…
chapuni Dec 27, 2024
764b14b
Merge branch 'main' into users/chapuni/cov/merge/summaryinfo
chapuni Dec 28, 2024
8c76999
Merge branch 'users/chapuni/cov/merge/summaryinfo' into users/chapuni…
chapuni Dec 28, 2024
85b1602
Merge branch 'users/chapuni/cov/merge/summaryinfo' into users/chapuni…
chapuni Dec 28, 2024
11f5cc5
Merge branch 'users/chapuni/cov/merge/mcdcsort-base' into users/chapu…
chapuni Dec 28, 2024
71b5be7
s/IsSummaryEmpty/isSummaryEmpty/
chapuni Jan 6, 2025
273a655
Merge branch 'main' into users/chapuni/cov/merge/mov_ind
chapuni Jan 7, 2025
ad6726d
Merge branch 'main' into users/chapuni/cov/merge/mcdcsort-base
chapuni Jan 7, 2025
10517c4
Merge branch 'main' into users/chapuni/cov/single/unify
chapuni Jan 7, 2025
c33e898
Merge branch 'users/chapuni/cov/single/unify' into users/chapuni/cov/…
chapuni Jan 7, 2025
fa45418
Merge branch 'users/chapuni/cov/merge/mcdcsort-base' into users/chapu…
chapuni Jan 7, 2025
3a9e417
Merge branch 'users/chapuni/cov/merge/mov_ind' into users/chapuni/cov…
chapuni Jan 7, 2025
9e57346
Merge branch 'users/chapuni/cov/merge/mov_ind' into users/chapuni/cov…
chapuni Jan 7, 2025
1ec6ebf
Merge branch 'users/chapuni/cov/single/unify' into users/chapuni/cov/…
chapuni Jan 7, 2025
5633a20
Merge branch 'users/chapuni/cov/merge/region_segment' into users/chap…
chapuni Jan 7, 2025
2c9593f
Merge branch 'users/chapuni/cov/merge/forfile-base' into users/chapun…
chapuni Jan 7, 2025
0e2d5d1
Merge branch 'users/chapuni/cov/merge/mov_ind' into users/chapuni/cov…
chapuni Jan 7, 2025
bb3bb71
Merge branch 'users/chapuni/cov/single/merge' into users/chapuni/cov/…
chapuni Jan 7, 2025
b93addb
Merge branch 'users/chapuni/cov/merge/forfile' into users/chapuni/cov…
chapuni Jan 7, 2025
694a772
Revert "Merge branch 'users/chapuni/cov/single/unify' into users/chap…
chapuni Jan 7, 2025
8a31621
Merge branch 'users/chapuni/cov/merge/mcdcsort' into users/chapuni/co…
chapuni Jan 7, 2025
24147ba
Merge branch 'users/chapuni/cov/merge/strategy' into users/chapuni/co…
chapuni Jan 7, 2025
2205a9a
Merge branch 'users/chapuni/cov/merge/merge-mcdc-base' into users/cha…
chapuni Jan 7, 2025
012afda
Merge branch 'users/chapuni/cov/merge/merge-mcdc' into users/chapuni/…
chapuni Jan 7, 2025
8afb2ff
Merge branch 'main' into users/chapuni/cov/merge/region_segment
chapuni Jan 10, 2025
0350c1e
Move mcdc-templates-merge.test from #121194
chapuni Jan 10, 2025
c4a2ca9
Merge branch 'users/chapuni/cov/merge/region_segment' into users/chap…
chapuni Jan 10, 2025
00ac189
Merge branch 'users/chapuni/cov/merge/forfile-base' into users/chapun…
chapuni Jan 10, 2025
33f28e8
Update tests
chapuni Jan 10, 2025
418a8be
Merge branch 'users/chapuni/cov/merge/forfile' into users/chapuni/cov…
chapuni Jan 10, 2025
bc24db6
Merge branch 'users/chapuni/cov/merge/strategy' into users/chapuni/co…
chapuni Jan 10, 2025
00ee8c7
Merge branch 'users/chapuni/cov/merge/merge-mcdc-base' into users/cha…
chapuni Jan 10, 2025
051f2ee
Merge branch 'users/chapuni/cov/merge/merge-mcdc' into users/chapuni/…
chapuni Jan 10, 2025
5cf0511
<numeric> std::iota
chapuni Jan 10, 2025
34ef28e
Merge branch 'users/chapuni/cov/merge/strategy' into users/chapuni/co…
chapuni Jan 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 91 additions & 6 deletions llvm/include/llvm/ProfileData/Coverage/CoverageMapping.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@ namespace coverage {
class CoverageMappingReader;
struct CoverageMappingRecord;

enum class MergeStrategy {
Merge,
Any,
All,
};

enum class coveragemap_error {
success = 0,
eof,
Expand Down Expand Up @@ -384,6 +390,32 @@ struct CountedRegion : public CounterMappingRegion {
: CounterMappingRegion(R), ExecutionCount(ExecutionCount),
FalseExecutionCount(FalseExecutionCount), TrueFolded(false),
FalseFolded(false) {}

LineColPair viewLoc() const { return startLoc(); }

bool isMergeable(const CountedRegion &RHS) const {
return (this->viewLoc() == RHS.viewLoc());
}

void merge(const CountedRegion &RHS, MergeStrategy Strategy);

/// Returns comparable rank value in selecting a better Record for merging.
auto getMergeRank(MergeStrategy Strategy) const {
assert(isBranch() && "Dedicated to Branch");
assert(Strategy == MergeStrategy::Any && "Dedicated to Any");
unsigned m = 0;
// Prefer both Counts have values.
m = (m << 1) | (ExecutionCount != 0 && FalseExecutionCount != 0);
// Prefer both are unfolded.
m = (m << 1) | (!TrueFolded && !FalseFolded);
// Prefer either Count has value.
m = (m << 1) | (ExecutionCount != 0 || FalseExecutionCount != 0);
// Prefer either is unfolded.
m = (m << 1) | (!TrueFolded || !FalseFolded);
return std::make_pair(m, ExecutionCount + FalseExecutionCount);
}

void commit() const {}
};

/// MCDC Record grouping all information together.
Expand Down Expand Up @@ -448,6 +480,7 @@ struct MCDCRecord {
}
};

using BitmapByCondTy = std::array<BitVector, 2>;
using TestVectors = llvm::SmallVector<std::pair<TestVector, CondState>>;
using BoolVector = std::array<BitVector, 2>;
using TVRowPair = std::pair<unsigned, unsigned>;
Expand All @@ -458,19 +491,36 @@ struct MCDCRecord {
private:
CounterMappingRegion Region;
TestVectors TV;
BitmapByCondTy BitmapByCond;
std::optional<TVPairMap> IndependencePairs;
BoolVector Folded;
CondIDMap PosToID;
LineColPairMap CondLoc;

public:
MCDCRecord(const CounterMappingRegion &Region, TestVectors &&TV,
BoolVector &&Folded, CondIDMap &&PosToID, LineColPairMap &&CondLoc)
: Region(Region), TV(std::move(TV)), Folded(std::move(Folded)),
BitmapByCondTy &&BitmapByCond, BoolVector &&Folded,
CondIDMap &&PosToID, LineColPairMap &&CondLoc)
: Region(Region), TV(std::move(TV)),
BitmapByCond(std::move(BitmapByCond)), Folded(std::move(Folded)),
PosToID(std::move(PosToID)), CondLoc(std::move(CondLoc)) {
findIndependencePairs();
}

inline LineColPair viewLoc() const { return Region.endLoc(); }

bool isMergeable(const MCDCRecord &RHS) const {
return (this->viewLoc() == RHS.viewLoc() &&
this->BitmapByCond[false].size() == RHS.BitmapByCond[true].size() &&
this->PosToID == RHS.PosToID && this->CondLoc == RHS.CondLoc);
}

// This may invalidate IndependencePairs
// MCDCRecord &operator+=(const MCDCRecord &RHS);
void merge(MCDCRecord &&RHS, MergeStrategy Strategy);

void commit() { findIndependencePairs(); }

// Compare executed test vectors against each other to find an independence
// pairs for each condition. This processing takes the most time.
void findIndependencePairs();
Expand Down Expand Up @@ -523,15 +573,43 @@ struct MCDCRecord {
return (*IndependencePairs)[PosToID[Condition]];
}

float getPercentCovered() const {
unsigned Folded = 0;
std::pair<unsigned, unsigned> getCoveredCount() const {
unsigned Covered = 0;
unsigned Folded = 0;
for (unsigned C = 0; C < getNumConditions(); C++) {
if (isCondFolded(C))
Folded++;
else if (isConditionIndependencePairCovered(C))
Covered++;
}
return {Covered, Folded};
}

/// Returns comparable rank value in selecting a better Record for merging.
std::tuple<unsigned, unsigned, unsigned>
getMergeRank(MergeStrategy Strategy) const {
auto [Covered, Folded] = getCoveredCount();
auto NumTVs = getNumTestVectors();
switch (Strategy) {
default:
llvm_unreachable("Not supported");
case MergeStrategy::Any:
return {
Covered, // The largest covered number
~Folded, // Less folded is better
NumTVs, // Show more test vectors
};
case MergeStrategy::All:
return {
~Covered, // The smallest covered number
~Folded, // Less folded is better
NumTVs, // Show more test vectors
};
}
}

float getPercentCovered() const {
auto [Covered, Folded] = getCoveredCount();

unsigned Total = getNumConditions() - Folded;
if (Total == 0)
Expand Down Expand Up @@ -900,6 +978,7 @@ class InstantiationGroup {
class CoverageData {
friend class CoverageMapping;

protected:
std::string Filename;
std::vector<CoverageSegment> Segments;
std::vector<ExpansionRecord> Expansions;
Expand All @@ -914,6 +993,8 @@ class CoverageData {
CoverageData(bool Single, StringRef Filename)
: Filename(Filename), SingleByteCoverage(Single) {}

CoverageData(CoverageData &&RHS) = default;

/// Get the name of the file this data covers.
StringRef getFilename() const { return Filename; }

Expand Down Expand Up @@ -1020,10 +1101,14 @@ class CoverageMapping {
/// The given filename must be the name as recorded in the coverage
/// information. That is, only names returned from getUniqueSourceFiles will
/// yield a result.
CoverageData getCoverageForFile(StringRef Filename) const;
CoverageData getCoverageForFile(
StringRef Filename, MergeStrategy Strategy = MergeStrategy::Merge,
const DenseSet<const FunctionRecord *> &FilteredOutFunctions = {}) const;

/// Get the coverage for a particular function.
CoverageData getCoverageForFunction(const FunctionRecord &Function) const;
CoverageData
getCoverageForFunction(const FunctionRecord &Function,
MergeStrategy Strategy = MergeStrategy::Merge) const;

/// Get the coverage for an expansion within a coverage set.
CoverageData getCoverageForExpansion(const ExpansionRecord &Expansion) const;
Expand Down
Loading
Loading