llvm-cov: Calculate RegionCoverage based on CoverageData::Segments
#121191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 27, 2024
ornata
reviewed
Jan 6, 2025
| // Compute the region coverage. | ||
| size_t NumCodeRegions = 0, CoveredRegions = 0; | ||
| for (auto &CR : CodeRegions) { | ||
| if (CR.Kind != CounterMappingRegion::CodeRegion) | ||
| for (auto I = CD.begin(), E = CD.end(); I != E; ++I) { |
There was a problem hiding this comment.
it's not possible to keep this as a range-based for?
There was a problem hiding this comment.
Iterators (for protected:Segments) are provided by CoverageData. I think range is less suitable here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Segmentsis more convenient for merging and shall be consistend to the visualization.On the other hand,
CountedRegionwas consitent since it was based onCounter. But it had a few problems.Depends on: #121189