-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[clang-tidy] fix incorrect argument names in documentation for ExtraArgs and ExtraArgsBefore #120963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rgs and ExtraArgsBefore
@llvm/pr-subscribers-clang-tidy Author: hill (float3) ChangesFull diff: https://github.com/llvm/llvm-project/pull/120963.diff 1 Files Affected:
diff --git a/clang-tools-extra/docs/clang-tidy/index.rst b/clang-tools-extra/docs/clang-tidy/index.rst
index f053e57e8d4c84..2d23ee57c681ec 100644
--- a/clang-tools-extra/docs/clang-tidy/index.rst
+++ b/clang-tools-extra/docs/clang-tidy/index.rst
@@ -282,8 +282,8 @@ An overview of all the command-line options:
globs can be specified as a list instead of a
string.
ExcludeHeaderFilterRegex - Same as '--exclude-header-filter'.
- ExtraArgs - Same as '--extra-args'.
- ExtraArgsBefore - Same as '--extra-args-before'.
+ ExtraArgs - Same as '--extra-arg'.
+ ExtraArgsBefore - Same as '--extra-arg-before'.
FormatStyle - Same as '--format-style'.
HeaderFileExtensions - File extensions to consider to determine if a
given diagnostic is located in a header file.
|
@llvm/pr-subscribers-clang-tools-extra Author: hill (float3) ChangesFull diff: https://github.com/llvm/llvm-project/pull/120963.diff 1 Files Affected:
diff --git a/clang-tools-extra/docs/clang-tidy/index.rst b/clang-tools-extra/docs/clang-tidy/index.rst
index f053e57e8d4c84..2d23ee57c681ec 100644
--- a/clang-tools-extra/docs/clang-tidy/index.rst
+++ b/clang-tools-extra/docs/clang-tidy/index.rst
@@ -282,8 +282,8 @@ An overview of all the command-line options:
globs can be specified as a list instead of a
string.
ExcludeHeaderFilterRegex - Same as '--exclude-header-filter'.
- ExtraArgs - Same as '--extra-args'.
- ExtraArgsBefore - Same as '--extra-args-before'.
+ ExtraArgs - Same as '--extra-arg'.
+ ExtraArgsBefore - Same as '--extra-arg-before'.
FormatStyle - Same as '--format-style'.
HeaderFileExtensions - File extensions to consider to determine if a
given diagnostic is located in a header file.
|
Sync with ClangTidyMain.cpp? llvm-project/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp Lines 57 to 58 in d36836d
|
I adjusted headerfilterregex as well as per #111405 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.