Temporarily disable test clang/Interpreter/crash.cpp

[yuxuanchen1997]

See discussion on #117475 (comment)

This test currently invokes the system ld, which can cause issues on some CI systems where system ld only works with $LDFLAGS and $LIBS. @vgvassilev has suggested to use the yaml2obj tool to avoid invoking ld.

Before that happens, proposing to disable this test until we find a solution to unblock downstream CI.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Yuxuan Chen (yuxuanchen1997)

Changes

See discussion on #117475 (comment)

This test currently invokes the system ld, which can cause issues on some CI systems where system ld only works with $LDFLAGS and $LIBS. @vgvassilev has suggested to use the yaml2obj tool to avoid invoking ld.

Before that happens, proposing to disable this test until we find a solution to unblock downstream CI.

---

Full diff: https://github.com/llvm/llvm-project/pull/119978.diff

1 Files Affected:

• (modified) clang/test/Interpreter/crash.cpp (+1)

diff --git a/clang/test/Interpreter/crash.cpp b/clang/test/Interpreter/crash.cpp
index 9a606983524d82..11ff938aedd5d5 100644
--- a/clang/test/Interpreter/crash.cpp
+++ b/clang/test/Interpreter/crash.cpp
@@ -1,4 +1,5 @@
 // REQUIRES: host-supports-jit, x86_64-linux
+// UNSUPPORTED: target={{.*}}
 
 // RUN: rm -rf %t
 // RUN: mkdir -p %t

[vgvassilev]

LGTM.

[carlocab]

Obsoleted by 61ab36a

[vgvassilev]

Obsoleted by 61ab36a

That was the right fix, not the revert...

[carlocab]

Obsoleted by 61ab36a

That was the right fix, not the revert...

I'm inclined to agree. Could revert the revert then apply this.

[yuxuanchen1997]

May I understand what's the intention of this? I would prefer that the original author figures out a solution that doesn't depend on system linker, which is what I would consider a proper fix.