Skip to content

[libc][stdfix] disable lkbits on riscv #115781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

nickdesaulniers
Copy link
Member

Link: #114912
Link: #115778

@llvmbot
Copy link
Member

llvmbot commented Nov 11, 2024

@llvm/pr-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

Changes

Link: #114912
Link: #115778


Full diff: https://github.com/llvm/llvm-project/pull/115781.diff

1 Files Affected:

  • (modified) libc/config/linux/riscv/entrypoints.txt (+2-1)
diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt
index f18d052dde2905..592188dee59ea7 100644
--- a/libc/config/linux/riscv/entrypoints.txt
+++ b/libc/config/linux/riscv/entrypoints.txt
@@ -727,7 +727,8 @@ if(LIBC_COMPILER_HAS_FIXED_POINT)
     libc.src.stdfix.uhkbits
     libc.src.stdfix.kbits
     libc.src.stdfix.ukbits
-    libc.src.stdfix.lkbits
+    # TODO: https://github.com/llvm/llvm-project/issues/115778
+    # libc.src.stdfix.lkbits
     libc.src.stdfix.ulkbits
   )
 endif()

@nickdesaulniers
Copy link
Member Author

cc @smallp-o-p

@nickdesaulniers nickdesaulniers merged commit 448d7da into llvm:main Nov 11, 2024
7 of 8 checks passed
@nickdesaulniers nickdesaulniers deleted the lkbits branch November 11, 2024 22:45
@nickdesaulniers
Copy link
Member Author

argh ulkbits also has this issue

@zeroomega
Copy link
Contributor

FAILED: libc/src/stdfix/CMakeFiles/libc.src.stdfix.ulkbits.dir/ulkbits.cpp.obj 
/b/s/w/ir/x/w/llvm_build/bin/clang++ --target=riscv32-unknown-elf -DLIBC_NAMESPACE=__llvm_libc_20_0_0_git -I/b/s/w/ir/x/w/llvm-llvm-project/libc -isystem /b/s/w/ir/x/w/llvm_build/include/riscv32-unknown-unknown-elf --target=riscv32-unknown-elf -march=rv32imc_zicsr_zifencei -mabi=ilp32 -Wno-atomic-alignment "-Dvfprintf(stream, format, vlist)=vprintf(format, vlist)" "-Dfprintf(stream, format, ...)=printf(format)" "-Dtimeval=struct timeval{int tv_sec; int tv_usec;}" "-Dgettimeofday(tv, tz)" -D_LIBCPP_PRINT=1 -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -ffunction-sections -fdata-sections -ffile-prefix-map=/b/s/w/ir/x/w/llvm_build/runtimes/runtimes-riscv32-unknown-elf=../../../llvm-llvm-project -ffile-prefix-map=/b/s/w/ir/x/w/llvm-llvm-project/= -no-canonical-prefixes -O2 -g -DNDEBUG -std=gnu++17 --target=riscv32-unknown-elf -DLIBC_QSORT_IMPL=LIBC_QSORT_HEAP_SORT -DLIBC_ADD_NULL_CHECKS -fpie -ffreestanding -DLIBC_FULL_BUILD -nostdlibinc -ffixed-point -fno-builtin -fno-exceptions -fno-lax-vector-conversions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -Wall -Wextra -Werror -Wconversion -Wno-sign-conversion -Wno-c99-extensions -Wno-gnu-imaginary-constant -Wno-pedantic -Wimplicit-fallthrough -Wwrite-strings -Wextra-semi -Wnewline-eof -Wnonportable-system-include-path -Wstrict-prototypes -Wthread-safety -Wglobal-constructors -DLIBC_COPT_PUBLIC_PACKAGING -MD -MT libc/src/stdfix/CMakeFiles/libc.src.stdfix.ulkbits.dir/ulkbits.cpp.obj -MF libc/src/stdfix/CMakeFiles/libc.src.stdfix.ulkbits.dir/ulkbits.cpp.obj.d -o libc/src/stdfix/CMakeFiles/libc.src.stdfix.ulkbits.dir/ulkbits.cpp.obj -c /b/s/w/ir/x/w/llvm-llvm-project/libc/src/stdfix/ulkbits.cpp
/b/s/w/ir/x/w/llvm-llvm-project/libc/src/stdfix/ulkbits.cpp:16:10: error: no matching function for call to 'bit_cast'
   16 |   return cpp::bit_cast<unsigned long accum, uint_ulk_t>(x);
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/s/w/ir/x/w/llvm-llvm-project/libc/src/__support/CPP/bit.h:38:1: note: candidate template ignored: substitution failure [with To = unsigned long _Accum, From = uint_ulk_t]: implicit instantiation of undefined template '__llvm_libc_20_0_0_git::cpp::enable_if<false, unsigned long _Accum>'
   38 | bit_cast(const From &from) {
      | ^
1 error generated.

We still see similar build failures on bit_cast after this patch was landed.

nickdesaulniers added a commit to nickdesaulniers/llvm-project that referenced this pull request Nov 12, 2024
I should have disabled this in llvm#115781. Mea culpa.

Link: llvm#114912
Link: llvm#115778
Link: llvm#115781
nickdesaulniers added a commit that referenced this pull request Nov 12, 2024
I should have disabled this in #115781. Mea culpa.

Link: #114912
Link: #115778
Link: #115781
Groverkss pushed a commit to iree-org/llvm-project that referenced this pull request Nov 15, 2024
Groverkss pushed a commit to iree-org/llvm-project that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants