Pass std::initializer_list by value to ArrayRef constructor. #113590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The std::initializer_list is a light-weight object, in general, it is
passed by value.
This would also avoid a false positive when adding the lifetimebound
annotation.
```
ArrayRef<int> foo(std::initializer_list<int> list) {
return ArrayRef<int>(list);
}
```
|
@llvm/pr-subscribers-llvm-adt Author: Haojian Wu (hokein) ChangesThe std::initializer_list is a lightweight object, it is passed by value in general. This would also avoid a false positive when adding the lifetimebound annotation (#113547) Full diff: https://github.com/llvm/llvm-project/pull/113590.diff 1 Files Affected:
diff --git a/llvm/include/llvm/ADT/ArrayRef.h b/llvm/include/llvm/ADT/ArrayRef.h
index d9897320ce091a..bf6b55923b84ba 100644
--- a/llvm/include/llvm/ADT/ArrayRef.h
+++ b/llvm/include/llvm/ADT/ArrayRef.h
@@ -113,7 +113,7 @@ namespace llvm {
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Winit-list-lifetime"
#endif
- constexpr /*implicit*/ ArrayRef(const std::initializer_list<T> &Vec)
+ constexpr /*implicit*/ ArrayRef(std::initializer_list<T> Vec)
: Data(Vec.begin() == Vec.end() ? (T *)nullptr : Vec.begin()),
Length(Vec.size()) {}
#if LLVM_GNUC_PREREQ(9, 0, 0)
|
Xazax-hun
approved these changes
Oct 24, 2024
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/7517 Here is the relevant piece of the build log for the reference |
Closed
NoumanAmir657
pushed a commit
to NoumanAmir657/llvm-project
that referenced
this pull request
Nov 4, 2024
…3590) The std::initializer_list is a lightweight object, it is passed by value in general. This would also avoid a false positive when adding the lifetimebound annotation (llvm#113547) ``` ArrayRef<int> foo(std::initializer_list<int> list) { return ArrayRef<int>(list); } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The std::initializer_list is a lightweight object, it is passed by value in general.
This would also avoid a false positive when adding the lifetimebound annotation (#113547)