Skip to content

[libc] Use if constexpr for compile-time conditionals #113417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged

[libc] Use if constexpr for compile-time conditionals #113417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions libc/test/UnitTest/FPMatcher.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,35 +124,35 @@ template <typename T, TestCond Condition> class CFPMatcher : public Matcher<T> {

bool match(T actualValue) {
actual = actualValue;
if (cpp::is_complex_type_same<T, _Complex float>())
if constexpr (cpp::is_complex_type_same<T, _Complex float>())
return matchComplex<float>();
else if (cpp::is_complex_type_same<T, _Complex double>())
else if constexpr (cpp::is_complex_type_same<T, _Complex double>())
return matchComplex<double>();
else if (cpp::is_complex_type_same<T, _Complex long double>())
else if constexpr (cpp::is_complex_type_same<T, _Complex long double>())
return matchComplex<long double>();
#ifdef LIBC_TYPES_HAS_CFLOAT16
else if (cpp::is_complex_type_same<T, cfloat16>)
else if constexpr (cpp::is_complex_type_same<T, cfloat16>)
return matchComplex<float16>();
#endif
#ifdef LIBC_TYPES_HAS_CFLOAT128
else if (cpp::is_complex_type_same<T, cfloat128>)
else if constexpr (cpp::is_complex_type_same<T, cfloat128>)
return matchComplex<float128>();
#endif
}

void explainError() override {
if (cpp::is_complex_type_same<T, _Complex float>())
if constexpr (cpp::is_complex_type_same<T, _Complex float>())
return explainErrorComplex<float>();
else if (cpp::is_complex_type_same<T, _Complex double>())
else if constexpr (cpp::is_complex_type_same<T, _Complex double>())
return explainErrorComplex<double>();
else if (cpp::is_complex_type_same<T, _Complex long double>())
else if constexpr (cpp::is_complex_type_same<T, _Complex long double>())
return explainErrorComplex<long double>();
#ifdef LIBC_TYPES_HAS_CFLOAT16
else if (cpp::is_complex_type_same<T, cfloat16>)
else if constexpr (cpp::is_complex_type_same<T, cfloat16>)
return explainErrorComplex<float16>();
#endif
#ifdef LIBC_TYPES_HAS_CFLOAT128
else if (cpp::is_complex_type_same<T, cfloat128>)
else if constexpr (cpp::is_complex_type_same<T, cfloat128>)
return explainErrorComplex<float128>();
#endif
}
Expand Down
Loading