Skip to content

[lldb] Fixed IPv6 host formatting in #104238 #111033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

slydiman
Copy link
Contributor

@slydiman slydiman commented Oct 3, 2024

This patch fixes the following problems https://lab.llvm.org/buildbot/#/builders/162/builds/7720

@llvmbot
Copy link
Member

llvmbot commented Oct 3, 2024

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

Changes

This patch fixes the following problems https://lab.llvm.org/buildbot/#/builders/162/builds/7720


Full diff: https://github.com/llvm/llvm-project/pull/111033.diff

1 Files Affected:

  • (modified) lldb/tools/lldb-server/lldb-platform.cpp (+2-2)
diff --git a/lldb/tools/lldb-server/lldb-platform.cpp b/lldb/tools/lldb-server/lldb-platform.cpp
index d1f925685dff91..2ef780578d0a28 100644
--- a/lldb/tools/lldb-server/lldb-platform.cpp
+++ b/lldb/tools/lldb-server/lldb-platform.cpp
@@ -142,8 +142,8 @@ static Status parse_listen_host_port(Socket::SocketProtocol &protocol,
       return Status::FromErrorStringWithFormat(
           "The same platform and gdb ports %u.", platform_port);
     }
-    address = llvm::formatv("{0}:{1}", hostname, platform_port).str();
-    gdb_address = llvm::formatv("{0}:{1}", hostname, gdbserver_port).str();
+    address = llvm::formatv("[{0}]:{1}", hostname, platform_port).str();
+    gdb_address = llvm::formatv("[{0}]:{1}", hostname, gdbserver_port).str();
   } else {
     if (gdbserver_port) {
       return Status::FromErrorStringWithFormat(

@slydiman slydiman merged commit 000e790 into llvm:main Oct 3, 2024
7 of 8 checks passed
@slydiman slydiman deleted the fix-lldb-server-ipv6-host branch April 18, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants