[LTO] Fix a use-after-free in legacy LTO C APIs #107896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
jhuber6
approved these changes
Sep 9, 2024
No worries. We kind of lack a bit test coverage in legacy API and it doesn't seem to be a good investment to fix that now. |
cachemeifyoucan
deleted the
users/cachemeifyoucan/spr/lto-fix-a-use-after-free-in-legacy-lto-c-apis
branch
cachemeifyoucan
added a commit
to cachemeifyoucan/llvm-project
that referenced
this pull request
Sep 9, 2024
Fix a bug that `lto_runtime_lib_symbols_list` is returning the address of a local variable that will be freed when getting out of scope. This is a regression from llvm#98512 that rewrites the runtime libcall function lists into a SmallVector. rdar://135559037 (cherry picked from commit 66e9078)
cachemeifyoucan
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Sep 9, 2024
Fix a bug that `lto_runtime_lib_symbols_list` is returning the address of a local variable that will be freed when getting out of scope. This is a regression from llvm#98512 that rewrites the runtime libcall function lists into a SmallVector. rdar://135559037 (cherry picked from commit 66e9078)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug that
lto_runtime_lib_symbols_listis returning the addressof a local variable that will be freed when getting out of scope. This
is a regression from #98512 that rewrites the runtime libcall function
lists into a SmallVector.
rdar://135559037