[libc++][test] Fix msvc_is_lock_free_macro_value()
#105876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #99570.
TEST_COMPILER_MSVC
must be tested fordefined
ness, as it is everywhere else.llvm-project/libcxx/test/support/test_macros.h
Lines 71 to 72 in 52a7116
llvm-project/libcxx/test/std/utilities/function.objects/func.not_fn/not_fn.pass.cpp
Line 248 in 52a7116
llvm-project\libcxx\test\support\atomic_helpers.h(33): fatal error C1017: invalid integer constant expression
msvc_is_lock_free_macro_value()
returns2
or0
, so it needs to returnint
.llvm-project\libcxx\test\support\atomic_helpers.h(41): warning C4305: 'return': truncation from 'int' to 'bool'