[RuntimeDyld][Windows] Allocate space for dllimport things. #102586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't taking account of the space we require in the stubs for things that are `dllimport`ed, and as a result we could hit the assertion failure for running out of stub space. Fix that. rdar://133473673
|
This is a cherry pick of swiftlang#9071. |
No need for `TargetName` to exist separately, really. Co-authored-by: Saleem Abdulrasool <[email protected]>
al45tair
force-pushed
the
eng/PR-133473673-upstream
branch
from
adaa01b to
8be77e9
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
Looks to me like the build passed just fine, but the attempt to print the |
|
@lhames Any chance you could review this upstream PR? Also, I don't have merge rights and I also don't see how to kick the PR testing apparatus into retrying the build here (the failures don't seem to be anything to do with the PR). |
bnbarham
reviewed
Aug 12, 2024
Fix `StringRef::starts_with` use. Co-authored-by: Ben Barham <[email protected]>
al45tair
added a commit
that referenced
this pull request
Sep 2, 2024
We weren't taking account of the space we require in the stubs for things that are dllimported, and as a result we could hit the assertion failure for running out of stub space. Fix that. Also add a couple of `override` specifiers that were missing last time (#102586). rdar://133473673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't taking account of the space we require in the stubs for things that are dllimported, and as a result we could hit the assertion failure for running out of stub space. Fix that.
rdar://133473673