-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[libc] Updated GettingStarted.rst with PyYAML version #100649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New Headergen requires PyYAML version 5.1 or newer in order to generate header files .
@@ -295,6 +295,7 @@ Package Version Notes | |||
`python <http://www.python.org/>`_ >=3.8 Automated test suite\ :sup:`1` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note: This looks like it's different from what is posted at
- Python Version: 3.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can edit the header generation page to match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@llvm/pr-subscribers-libc Author: None (RoseZhang03) ChangesNew Headergen requires PyYAML version 5.1 or newer in order to generate Full diff: https://github.com/llvm/llvm-project/pull/100649.diff 2 Files Affected:
diff --git a/libc/docs/dev/header_generation.rst b/libc/docs/dev/header_generation.rst
index 32ce91da83f3d..598c8b8c8a6e8 100644
--- a/libc/docs/dev/header_generation.rst
+++ b/libc/docs/dev/header_generation.rst
@@ -22,7 +22,7 @@ Instructions
------------
Required Versions:
- - Python Version: 3.6
+ - Python Version: 3.8
- PyYAML Version: 5.1
1. Keep full-build mode on when building, otherwise headers will not be
diff --git a/llvm/docs/GettingStarted.rst b/llvm/docs/GettingStarted.rst
index 0a1913dca8aac..e03ae5effcdc4 100644
--- a/llvm/docs/GettingStarted.rst
+++ b/llvm/docs/GettingStarted.rst
@@ -291,10 +291,11 @@ uses the package and provides other details.
=========================================================== ============ ==========================================
Package Version Notes
=========================================================== ============ ==========================================
-`CMake <http://cmake.org/>`__ >=3.20.0 Makefile/workspace generator
+`CMake <http://cmake.org/>`_ >=3.20.0 Makefile/workspace generator
`python <http://www.python.org/>`_ >=3.8 Automated test suite\ :sup:`1`
`zlib <http://zlib.net>`_ >=1.2.3.4 Compression library\ :sup:`2`
`GNU Make <http://savannah.gnu.org/projects/make>`_ 3.79, 3.79.1 Makefile/build processor\ :sup:`3`
+`PyYAML <https://pypi.org/project/PyYAML/>`_ >=5.1 Header generator\ :sup:`4`
=========================================================== ============ ==========================================
.. note::
@@ -305,6 +306,7 @@ Package Version Notes
#. Optional, adds compression / uncompression capabilities to selected LLVM
tools.
#. Optional, you can use any other build tool supported by CMake.
+ #. Only needed when building libc with New Headergen. Mainly used by libc.
Additionally, your compilation host is expected to have the usual plethora of
Unix utilities. Specifically:
|
New Headergen requires PyYAML version 5.1 or newer in order to generate
header files .