MTM: fix issues after cursory reading #100404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artagnon
changed the title
nikic
reviewed
Jul 25, 2024
| @@ -146,15 +140,14 @@ MachineTraceMetrics::getProcReleaseAtCycles(unsigned MBBNum) const { | |||
| "getResources() must be called before getProcReleaseAtCycles()"); | |||
| unsigned PRKinds = SchedModel.getNumProcResourceKinds(); | |||
| assert((MBBNum+1) * PRKinds <= ProcReleaseAtCycles.size()); | |||
| return ArrayRef(ProcReleaseAtCycles.data() + MBBNum * PRKinds, PRKinds); | |||
| return ArrayRef{ProcReleaseAtCycles.data() + MBBNum * PRKinds, PRKinds}; | |||
There was a problem hiding this comment.
We don't really use ClassName{} style constructors inside LLVM unless there is some specific reason to do so. This should either stay as ArrayRef() or become {} without mentioning the name at all.
joker-eph
added a commit
that referenced
this pull request
Jul 25, 2024
This reverts commit 0760aec.
joker-eph
added a commit
that referenced
this pull request
Jul 25, 2024
Reverts #100404 This broke the gcc7 build here: https://lab.llvm.org/buildbot/#/builders/116/builds/1724
|
This broke the gcc7 build here: https://lab.llvm.org/buildbot/#/builders/116/builds/1724 , I reverted for now to unbreak. |
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250547
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
Summary: Reverts #100404 This broke the gcc7 build here: https://lab.llvm.org/buildbot/#/builders/116/builds/1724 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.