-
Notifications
You must be signed in to change notification settings - Fork 13.7k
MTM: fix issues after cursory reading #100404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -146,15 +140,14 @@ MachineTraceMetrics::getProcReleaseAtCycles(unsigned MBBNum) const { | |||
"getResources() must be called before getProcReleaseAtCycles()"); | |||
unsigned PRKinds = SchedModel.getNumProcResourceKinds(); | |||
assert((MBBNum+1) * PRKinds <= ProcReleaseAtCycles.size()); | |||
return ArrayRef(ProcReleaseAtCycles.data() + MBBNum * PRKinds, PRKinds); | |||
return ArrayRef{ProcReleaseAtCycles.data() + MBBNum * PRKinds, PRKinds}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really use ClassName{}
style constructors inside LLVM unless there is some specific reason to do so. This should either stay as ArrayRef()
or become {}
without mentioning the name at all.
This reverts commit 0760aec.
Reverts #100404 This broke the gcc7 build here: https://lab.llvm.org/buildbot/#/builders/116/builds/1724
This broke the gcc7 build here: https://lab.llvm.org/buildbot/#/builders/116/builds/1724 , I reverted for now to unbreak. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250547
Summary: Reverts #100404 This broke the gcc7 build here: https://lab.llvm.org/buildbot/#/builders/116/builds/1724 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250678
No description provided.