Skip to content

[mlir][spirv] Update dependencies for #100138 #100397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

angelz913
Copy link
Contributor

This PR updates CMake and Bazel dependencies for #100138.

@llvmbot llvmbot added mlir:spirv mlir bazel "Peripheral" support tier build system: utils/bazel labels Jul 24, 2024
@llvmbot
Copy link
Member

llvmbot commented Jul 24, 2024

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-spirv

Author: Angel Zhang (angelz913)

Changes

This PR updates CMake and Bazel dependencies for #100138.


Full diff: https://github.com/llvm/llvm-project/pull/100397.diff

4 Files Affected:

  • (modified) mlir/lib/Conversion/ConvertToSPIRV/CMakeLists.txt (+1)
  • (modified) mlir/lib/Dialect/SPIRV/Transforms/CMakeLists.txt (+1)
  • (modified) utils/bazel/llvm-project-overlay/mlir/BUILD.bazel (+2)
  • (modified) utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel (+1)
diff --git a/mlir/lib/Conversion/ConvertToSPIRV/CMakeLists.txt b/mlir/lib/Conversion/ConvertToSPIRV/CMakeLists.txt
index f7b090acf33af..c9d962d2de23f 100644
--- a/mlir/lib/Conversion/ConvertToSPIRV/CMakeLists.txt
+++ b/mlir/lib/Conversion/ConvertToSPIRV/CMakeLists.txt
@@ -27,6 +27,7 @@ add_mlir_conversion_library(MLIRConvertToSPIRVPass
   MLIRTransforms
   MLIRTransformUtils
   MLIRUBToSPIRV
+  MLIRVectorDialect
   MLIRVectorToSPIRV
   MLIRVectorTransforms
   )
diff --git a/mlir/lib/Dialect/SPIRV/Transforms/CMakeLists.txt b/mlir/lib/Dialect/SPIRV/Transforms/CMakeLists.txt
index 4de9b4729e720..68e0206e30a59 100644
--- a/mlir/lib/Dialect/SPIRV/Transforms/CMakeLists.txt
+++ b/mlir/lib/Dialect/SPIRV/Transforms/CMakeLists.txt
@@ -20,6 +20,7 @@ add_mlir_dialect_library(MLIRSPIRVConversion
   MLIRDialectUtils
   MLIRFuncDialect
   MLIRIR
+  MLIRPass
   MLIRSPIRVDialect
   MLIRSupport
   MLIRTransformUtils
diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index 0d0224e6d6802..536c8256b4274 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -7158,6 +7158,7 @@ cc_library(
         ":DialectUtils",
         ":FuncDialect",
         ":IR",
+        ":Pass",
         ":SPIRVDialect",
         ":Support",
         ":TransformUtils",
@@ -8319,6 +8320,7 @@ cc_library(
         ":TransformUtils",
         ":Transforms",
         ":UBToSPIRV",
+        ":VectorDialect",
         ":VectorToSPIRV",
         ":VectorTransforms",
     ],
diff --git a/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
index a1d2b20a106e6..34beb758a12dd 100644
--- a/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
@@ -668,6 +668,7 @@ cc_library(
         "//mlir:TransformUtils",
         "//mlir:Transforms",
         "//mlir:VectorDialect",
+        "//mlir:VectorTransforms",
     ],
 )
 

@kuhar kuhar merged commit 5898a7f into llvm:main Jul 24, 2024
9 of 10 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Jul 24, 2024

LLVM Buildbot has detected a new failure on builder clang-aarch64-sve-vls running on linaro-g3-02 while building mlir at step 7 "ninja check 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/143/builds/876

Here is the relevant piece of the build log for the reference:

Step 7 (ninja check 1) failure: 1200 seconds without output running [b'ninja', b'check-all'], attempting to kill
...
PASS: lld :: MachO/loh-adrp-ldr.s (91483 of 91493)
PASS: mlgo-utils :: corpus/extract_ir_script.test (91484 of 91493)
PASS: lld :: MachO/loh-adrp-ldr-got-ldr.s (91485 of 91493)
PASS: lld :: wasm/lto/thinlto.ll (91486 of 91493)
PASS: lld :: wasm/libsearch.s (91487 of 91493)
PASS: mlgo-utils :: corpus/extract_ir_test.py (91488 of 91493)
PASS: lld :: MinGW/driver.test (91489 of 91493)
PASS: lld :: MachO/loh-adrp-add.s (91490 of 91493)
PASS: libFuzzer-aarch64-default-Linux :: minimize_crash.test (91491 of 91493)
PASS: libFuzzer-aarch64-default-Linux :: value-profile-load.test (91492 of 91493)
command timed out: 1200 seconds without output running [b'ninja', b'check-all'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=1672.845845

yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
Summary: This PR updates CMake and Bazel dependencies for #100138.

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60250565
@angelz913 angelz913 deleted the update-dependencies branch July 25, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel "Peripheral" support tier build system: utils/bazel mlir:spirv mlir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants