Skip to content

llvm/test/Transforms/SampleProfile/csspgo-import-list.ll fails in -DLLVM_ENABLE_EXPENSIVE_CHECKS=on builds #97108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MaskRay opened this issue Jun 28, 2024 · 1 comment · Fixed by #99378
Closed

llvm/test/Transforms/SampleProfile/csspgo-import-list.ll fails in -DLLVM_ENABLE_EXPENSIVE_CHECKS=on builds #97108

MaskRay opened this issue Jun 28, 2024 · 1 comment · Fixed by #99378
Assignees
@wlei-llvm
Labels
ipo Interprocedural optimizations

Comments

@MaskRay
Copy link
Member

MaskRay commented Jun 28, 2024

The test fails in -DLLVM_ENABLE_EXPENSIVE_CHECKS=on -DLLVM_ENABLE_ASSERTIONS=on builds, both Debug and Release.

At llvm/lib/Transforms/IPO/SampleProfile.cpp:1420, the initialized NewCandidate may have a null CalleeSamples, leading to assert(LCS && RCS && "Expect non-null FunctionSamples"); failure in (anonymous namespace)::CandidateComparer::operator()

@WenleiHe
@WenleiHe
Copy link
Member

Thanks for flagging, we will take a look.

@wlei-llvm wlei-llvm mentioned this issue Jul 17, 2024
Merged
wlei-llvm added a commit that referenced this issue Jul 18, 2024
@wlei-llvm
Fix assertion of null pointer samples in inline replay mode (#99378)
ce8c43f 
Fix #97108. In inline replay
mode, `CalleeSamples` may be null and the order doesn't matter.
@EugeneZelenko EugeneZelenko added ipo Interprocedural optimizations and removed test-suite llvm:transforms labels Jul 18, 2024
yuxuanchen1997 pushed a commit that referenced this issue Jul 25, 2024
@wlei-llvm @yuxuanchen1997
Fix assertion of null pointer samples in inline replay mode (#99378)
2493286 
Summary:
Fix #97108. In inline replay
mode, `CalleeSamples` may be null and the order doesn't matter.

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60250889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlei-llvm wlei-llvm

Labels
ipo Interprocedural optimizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix assertion of null pointer samples in inline replay mode wlei-llvm/llvm-project
4 participants
@MaskRay @EugeneZelenko @wlei-llvm @WenleiHe