-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Orc global constructor order test fails on 32 bit ARM #95911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@llvm/issue-subscribers-orcjit Author: David Spickett (DavidSpickett)
The test added by https://github.com//pull/95532 has exposed a pre-existing issue on Arm 32 bit.
https://lab.llvm.org/buildbot/#/builders/154/builds/170 The test expects to see each constructor print a string, but this is what we get:
We know it isn't because of the added
This may be due to relocations to the strings for those constructors not being resolved. Potentially it is the same problem as #94994. |
@llvm/issue-subscribers-backend-arm Author: David Spickett (DavidSpickett)
The test added by https://github.com//pull/95532 has exposed a pre-existing issue on Arm 32 bit.
https://lab.llvm.org/buildbot/#/builders/154/builds/170 The test expects to see each constructor print a string, but this is what we get:
We know it isn't because of the added
This may be due to relocations to the strings for those constructors not being resolved. Potentially it is the same problem as #94994. |
Reland and disable the test for ARM: d97951e |
@llvm/issue-subscribers-jitlink Author: David Spickett (DavidSpickett)
The test added by https://github.com//pull/95532 has exposed a pre-existing issue on Arm 32 bit.
https://lab.llvm.org/buildbot/#/builders/154/builds/170 The test expects to see each constructor print a string, but this is what we get:
We know it isn't because of the added
This may be due to relocations to the strings for those constructors not being resolved. Potentially it is the same problem as #94994. |
…#97030) The ARM architecture uses the LSB bit for ARM/Thumb mode switch flagging. This is true for alignments of 2 and 4 but in data relocations the alignment is 1 allowing the LSB bit to be set. Now only `ELF::STT_FUNC` typed symbols are used in the TargetFlag mechanism. The test is a minimal example of the issue mentioned below. Fixes llvm#95911 "Orc global constructor order test fails on 32 bit ARM".
The test added by #95532 has exposed a pre-existing issue on Arm 32 bit.
https://lab.llvm.org/buildbot/#/builders/154/builds/170
The test expects to see each constructor print a string, but this is what we get:
We know it isn't because of the added
stable sort
because the output order changes when I remove it but the gaps remain:This may be due to relocations to the strings for those constructors not being resolved. Potentially it is the same problem as #94994.
The text was updated successfully, but these errors were encountered: