Skip to content

[ADT] Add DenseMap::insert_or_assign #94115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikic opened this issue Jun 1, 2024 · 3 comments · Fixed by #94151
Closed

[ADT] Add DenseMap::insert_or_assign #94115

nikic opened this issue Jun 1, 2024 · 3 comments · Fixed by #94151
Assignees
Labels
good first issue https://github.com/llvm/llvm-project/contribute llvm:adt

Comments

@nikic
Copy link
Contributor

nikic commented Jun 1, 2024

It would be nice to add a C++17 style insert_or_assign method to DenseMap. It was previously added to MapVector in #71969.

@nikic nikic added good first issue https://github.com/llvm/llvm-project/contribute llvm:adt labels Jun 1, 2024
@nikic nikic changed the title Add DenseMap::insert_or_assign [ADT] Add DenseMap::insert_or_assign Jun 1, 2024
@llvmbot
Copy link
Member

llvmbot commented Jun 1, 2024

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
  2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
  3. Fix the issue locally.
  4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  5. Create a Git commit.
  6. Run git clang-format HEAD~1 to format your changes.
  7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

@llvmbot
Copy link
Member

llvmbot commented Jun 1, 2024

@llvm/issue-subscribers-good-first-issue

Author: Nikita Popov (nikic)

It would be nice to add a C++17 style insert_or_assign method to DenseMap. It was previously added to MapVector in https://github.com//pull/71969.

@cjkenn
Copy link

cjkenn commented Jun 1, 2024

Seems pretty reasonable, I'd like to take a crack at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue https://github.com/llvm/llvm-project/contribute llvm:adt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants