Skip to content

[BUG][clang-tidy-diff] SyntaxWarning: invalid escape sequence #92948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Jacobfaib opened this issue May 21, 2024 · 1 comment
Closed

[BUG][clang-tidy-diff] SyntaxWarning: invalid escape sequence #92948

Jacobfaib opened this issue May 21, 2024 · 1 comment
Labels
clang-tidy

Comments

@Jacobfaib
Copy link 

clang-tidy-diff.py:245: SyntaxWarning: invalid escape sequence '\+'
  match = re.search('^\+\+\+\ "?(.*?/){%s}([^ \t\n"]*)' % args.p, line)
clang-tidy-diff.py:258: SyntaxWarning: invalid escape sequence '\+'
  match = re.search("^@@.*\+(\d+)(,(\d+))?", line)

Using python:

$ python3 -VV
Python 3.12.3 (main, Apr  9 2024, 08:09:14) [Clang 15.0.0 (clang-1500.3.9.4)]

It seems these strings need to be raw strings:

match = re.search(r'^\+\+\+\ "?(.*?/){%s}([^ \t\n"]*)' % args.p, line)
#                 ^ note
@Jacobfaib Jacobfaib changed the title [BUG][clang-tidy] SyntaxWarning: invalid escape sequence [BUG][clang-tidy-diff] SyntaxWarning: invalid escape sequence May 21, 2024
@PiotrZSL PiotrZSL linked a pull request May 21, 2024 that will close this issue
fix(python): fix invalid escape sequences #91856
Closed
@5chmidti
Copy link
Contributor

Fixed by #94028

dagardner-nv added a commit to dagardner-nv/MRC that referenced this issue Feb 21, 2025
@dagardner-nv
Work-around invalid regex strings in clang-tidy llvm/llvm-project#92948
cb64976
This was referenced Feb 21, 2025
Open
Closed
willkill07 pushed a commit to willkill07/MRC that referenced this issue Feb 24, 2025
@dagardner-nv @willkill07
Work-around invalid regex strings in clang-tidy llvm/llvm-project#92948
9fe02e9
@willkill07 willkill07 mentioned this issue Feb 24, 2025
Merged
3 tasks
willkill07 pushed a commit to willkill07/MRC that referenced this issue Feb 24, 2025
@dagardner-nv @willkill07
Work-around invalid regex strings in clang-tidy llvm/llvm-project#92948
f917c0d
rapids-bot bot pushed a commit to nv-morpheus/MRC that referenced this issue Feb 25, 2025
@willkill07
Adopt Python 3.12 (#544)
bae997f 
This is #541 but having all commits rebased on `branch-25.06`

* `pybind11::error_already_set` now inherits from `std::exception` rather than `std::runtime_error`
* Adopt Pybind11 2.12, required for Python 3.12 support
* Disable Pybind's ing_ref/dec_ref checking (#542)
* Adopt updated version of versioneer, removing the need for `versioneer.py` in the repo.
* Work-around for llvm/llvm-project#92948 ref: #543
* Fetch commit history so proper version can be detected for tests

Authors:
  - Will Killian (https://github.com/willkill07)
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: #544
KyleFromNVIDIA pushed a commit to KyleFromNVIDIA/MRC that referenced this issue Apr 23, 2025
@willkill07 @KyleFromNVIDIA
Adopt Python 3.12 (nv-morpheus#544)
3e44744 
This is nv-morpheus#541 but having all commits rebased on `branch-25.06`

* `pybind11::error_already_set` now inherits from `std::exception` rather than `std::runtime_error`
* Adopt Pybind11 2.12, required for Python 3.12 support
* Disable Pybind's ing_ref/dec_ref checking (nv-morpheus#542)
* Adopt updated version of versioneer, removing the need for `versioneer.py` in the repo.
* Work-around for llvm/llvm-project#92948 ref: nv-morpheus#543
* Fetch commit history so proper version can be detected for tests

Authors:
  - Will Killian (https://github.com/willkill07)
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: nv-morpheus#544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clang-tidy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(python): fix invalid escape sequences e-kwsm/llvm-project
2 participants
@Jacobfaib @5chmidti