Skip to content

Add tests for #90292 #92128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vitalybuka opened this issue May 14, 2024 · 1 comment · Fixed by #110210
Closed

Add tests for #90292 #92128

vitalybuka opened this issue May 14, 2024 · 1 comment · Fixed by #110210
Assignees
@vitalybuka
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. test-suite

Comments

@vitalybuka
Copy link
Collaborator

vitalybuka commented May 14, 2024 •
edited
Loading

Test #90292 using a custom allocator.
@vitalybuka vitalybuka added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label May 14, 2024
@vitalybuka vitalybuka self-assigned this May 14, 2024
@ldionne
Copy link
Member

ldionne commented Sep 10, 2024

Gentle ping on this @vitalybuka

@vitalybuka vitalybuka mentioned this issue Sep 27, 2024
Merged
vitalybuka added a commit that referenced this issue Oct 1, 2024
@vitalybuka @ldionne
[libc++][string] Add regression test for sized new/delete bug (#110210)
eea5e7e 
This is regression test for #90292.

Allocator used in test is very similar to test_allocator.
However, reproducer requires size_type of the string
to be 64bit, but test_allocator uses 32bit.

32bit size_type makes `sizeof(string::__long)` to be 16,
but the alignment issue fixed with #90292 is only triggered
with default `sizeof(string::__long)` which is 24.

Fixes #92128.

---------

Co-authored-by: Louis Dionne <[email protected]>
Sterling-Augustine pushed a commit to Sterling-Augustine/llvm-project that referenced this issue Oct 3, 2024
@vitalybuka @ldionne @Sterling-Augustine
[libc++][string] Add regression test for sized new/delete bug (llvm#1…
a7316f5 
…10210)

This is regression test for llvm#90292.

Allocator used in test is very similar to test_allocator.
However, reproducer requires size_type of the string
to be 64bit, but test_allocator uses 32bit.

32bit size_type makes `sizeof(string::__long)` to be 16,
but the alignment issue fixed with llvm#90292 is only triggered
with default `sizeof(string::__long)` which is 24.

Fixes llvm#92128.

---------

Co-authored-by: Louis Dionne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitalybuka vitalybuka

Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. test-suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[libc++][string] Add regression test for sized new/delete bug llvm/llvm-project
3 participants
@ldionne @vitalybuka @EugeneZelenko