Skip to content

[mlir][spirv] Add integration tests for vector.shuffle / vector.interleave #91978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kuhar opened this issue May 13, 2024 · 9 comments
Closed

Comments

@kuhar
Copy link
Member

kuhar commented May 13, 2024

These go through several layers of decomposition / unrolling / emulation when targeting SPIR-V and it would be good to have e2e coverage there.

The new tests should be added under: https://github.com/llvm/llvm-project/tree/main/mlir/test/mlir-vulkan-runner

@kuhar kuhar added mlir:spirv help wanted Indicates that a maintainer wants help. Not [good first issue]. good first issue https://github.com/llvm/llvm-project/contribute labels May 13, 2024
@llvmbot
Copy link
Member

llvmbot commented May 13, 2024

@llvm/issue-subscribers-mlir-spirv

Author: Jakub Kuderski (kuhar)

These go through several layers of decomposition / unrolling / emulation when targeting SPIR-V and it would be good to have e2e coverage there.

The new tests should be added under: https://github.com/llvm/llvm-project/tree/main/mlir/test/mlir-vulkan-runner

@llvmbot
Copy link
Member

llvmbot commented May 13, 2024

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
  2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
  3. Fix the issue locally.
  4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  5. Create a Git commit.
  6. Run git clang-format HEAD~1 to format your changes.
  7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

@llvmbot
Copy link
Member

llvmbot commented May 13, 2024

@llvm/issue-subscribers-good-first-issue

Author: Jakub Kuderski (kuhar)

These go through several layers of decomposition / unrolling / emulation when targeting SPIR-V and it would be good to have e2e coverage there.

The new tests should be added under: https://github.com/llvm/llvm-project/tree/main/mlir/test/mlir-vulkan-runner

@Rajveer100
Copy link
Contributor

@kuhar
Could you give a comprehensive insight about what has to be done?

@joker-eph
Copy link
Collaborator

Can we avoid using the Vulcan runner and start writing tests using the mlir-cpu-runner by now? Is there anything missing?

@rengolin
Copy link
Member

Can we avoid using the Vulcan runner and start writing tests using the mlir-cpu-runner by now? Is there anything missing?

Agreed. We should probably create a plan to deprecate the vulkan runner and rename the mlir-cpu-runner into just mlir-runner.

@kuhar
Copy link
Member Author

kuhar commented May 14, 2024

@antiagainst for vulkan runner impl

@kuhar
Copy link
Member Author

kuhar commented May 14, 2024

Ah, we have a tracking issue for vulkarn runner already: #73457

@antiagainst
Copy link
Member

Yes. An there are interested contributors there. I asked them about the updates. To me the test is disjoint to the harness though. I think we should be able to add more tests while upgrading the harness.

@kuhar kuhar changed the title [mlir][spirv] Add vulkan runner integration tests for vector.shuffle / vector.interleave [mlir][spirv] Add integration tests for vector.shuffle / vector.interleave May 16, 2024
@kuhar kuhar removed help wanted Indicates that a maintainer wants help. Not [good first issue]. good first issue https://github.com/llvm/llvm-project/contribute labels May 16, 2024
kuhar added a commit that referenced this issue May 29, 2024
…r.shuffle` (#93595)

- Add integration test for `vector.shuffle` and `vector.interleave`,
mentioned in issue #91978
- Add `VectorToSPIRV` patterns to `GPUToSPIRVPass`

---------

Co-authored-by: Jakub Kuderski <[email protected]>
@kuhar kuhar closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants