Skip to content

lldb/tools/debugserver/source/JSON.cpp: 4 * Clumsy string output #91212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dcb314 opened this issue May 6, 2024 · 1 comment · Fixed by #94839
Closed

lldb/tools/debugserver/source/JSON.cpp: 4 * Clumsy string output #91212

dcb314 opened this issue May 6, 2024 · 1 comment · Fixed by #94839
Labels
code-quality lldb

Comments

@dcb314
Copy link

dcb314 commented May 6, 2024

Static analyser cppcheck says:

lldb/tools/debugserver/source/JSON.cpp:398:19: performance: Passing the result of c_str() to a stream is slow and redundant. [stlcstrStream]

Source code is

        error << "error: got exponent character but no exponent digits at "
                 "offset in float value \""
              << value.c_str() << "\"";

Some duplicates:

lldb/tools/debugserver/source/JSON.cpp:408:64: performance: Passing the result of c_str() to a stream is slow and redundant. [stlcstrStream]
lldb/tools/debugserver/source/JSON.cpp:420:54: performance: Passing the result of c_str() to a stream is slow and redundant. [stlcstrStream]
lldb/tools/debugserver/source/JSON.cpp:46:13: performance: Passing the result of c_str() to a stream is slow and redundant. [stlcstrStream]
@llvmbot
Copy link
Member

llvmbot commented May 6, 2024

@llvm/issue-subscribers-lldb

Author: None (dcb314)

Static analyser cppcheck says:

lldb/tools/debugserver/source/JSON.cpp:398:19: performance: Passing the result of c_str() to a stream is slow and redundant. [stlcstrStream]

Source code is

        error &lt;&lt; "error: got exponent character but no exponent digits at "
                 "offset in float value \""
              &lt;&lt; value.c_str() &lt;&lt; "\"";

Some duplicates:

lldb/tools/debugserver/source/JSON.cpp:408:64: performance: Passing the result of c_str() to a stream is slow and redundant. [stlcstrStream]
lldb/tools/debugserver/source/JSON.cpp:420:54: performance: Passing the result of c_str() to a stream is slow and redundant. [stlcstrStream]
lldb/tools/debugserver/source/JSON.cpp:46:13: performance: Passing the result of c_str() to a stream is slow and redundant. [stlcstrStream]

xgupta added a commit to xgupta/llvm-project that referenced this issue Jun 8, 2024
@xgupta
[lldb] Remove redundant c_str() calls in stream output (NFC)
530ef90 
Passing the result of c_str() to a stream is slow and redundant.
This change removes unnecessary c_str() calls and uses the string object directly.

Caught by cppcheck -
lldb/tools/debugserver/source/JSON.cpp:398:19: performance: Passing the result of c_str() to a stream is slow and redundant. [stlcstrStream]
lldb/tools/debugserver/source/JSON.cpp:408:64: performance: Passing the result of c_str() to a stream is slow and redundant. [stlcstrStream]
lldb/tools/debugserver/source/JSON.cpp:420:54: performance: Passing the result of c_str() to a stream is slow and redundant. [stlcstrStream]
lldb/tools/debugserver/source/JSON.cpp:46:13: performance: Passing the result of c_str() to a stream is slow and redundant. [stlcstrStream]

Fix llvm#91212
@xgupta xgupta mentioned this issue Jun 8, 2024
Merged
xgupta added a commit that referenced this issue Jun 8, 2024
@xgupta
[lldb] Remove redundant c_str() calls in stream output (NFC) (#94839)
d3fc5cf 
Passing the result of c_str() to a stream is slow and redundant. This
change removes unnecessary c_str() calls and uses the string object
directly.

Caught by cppcheck -
lldb/tools/debugserver/source/JSON.cpp:398:19: performance: Passing the
result of c_str() to a stream is slow and redundant. [stlcstrStream]
lldb/tools/debugserver/source/JSON.cpp:408:64: performance: Passing the
result of c_str() to a stream is slow and redundant. [stlcstrStream]
lldb/tools/debugserver/source/JSON.cpp:420:54: performance: Passing the
result of c_str() to a stream is slow and redundant. [stlcstrStream]
lldb/tools/debugserver/source/JSON.cpp:46:13: performance: Passing the
result of c_str() to a stream is slow and redundant. [stlcstrStream]

Fix #91212
nekoshirro pushed a commit to nekoshirro/Alchemist-LLVM that referenced this issue Jun 9, 2024
@xgupta @nekoshirro
[lldb] Remove redundant c_str() calls in stream output (NFC) (llvm#94839
f2d49dc 
)

Passing the result of c_str() to a stream is slow and redundant. This
change removes unnecessary c_str() calls and uses the string object
directly.

Caught by cppcheck -
lldb/tools/debugserver/source/JSON.cpp:398:19: performance: Passing the
result of c_str() to a stream is slow and redundant. [stlcstrStream]
lldb/tools/debugserver/source/JSON.cpp:408:64: performance: Passing the
result of c_str() to a stream is slow and redundant. [stlcstrStream]
lldb/tools/debugserver/source/JSON.cpp:420:54: performance: Passing the
result of c_str() to a stream is slow and redundant. [stlcstrStream]
lldb/tools/debugserver/source/JSON.cpp:46:13: performance: Passing the
result of c_str() to a stream is slow and redundant. [stlcstrStream]

Fix llvm#91212

Signed-off-by: Hafidz Muzakky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality lldb
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[lldb] Remove redundant c_str() calls in stream output (NFC) xgupta/llvm-project
2 participants
@dcb314 @llvmbot