Skip to content

[libc] Add proxy header for fenv.h macro constants. #87863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks
lntue opened this issue Apr 6, 2024 · 2 comments
Closed
5 tasks

[libc] Add proxy header for fenv.h macro constants. #87863

lntue opened this issue Apr 6, 2024 · 2 comments
Labels

Comments

@lntue
Copy link
Contributor

lntue commented Apr 6, 2024

Context: #87017 #87598

Add a proxy header for fenv.h macro constants so that our implementations and tests will work nicely for both overlay and full build modes.

  • Add libc/hdr/fenv_macros.h that will include the system <fenv.h> in overlay mode or include libc/include/llvm-libc-macros/fenv-macros.h in full build mode. (See for instance libc/hdr/math_macros.h ).
  • Add its corresponding cmake target in libc/hdr/CMakeLists.txt.
  • Replacing as many #include <fenv.h> and cmake target dependency on libc.include.fenv as possible, and document where those inclusion cannot be removed yet (due to usage of types or functions defined in fenv.h)
  • Add hdr_fenv_macros target in utils/bazel/llvm-project-overlay/libc/BUILD.bazel.
  • Update dependencies to all targets that include hdr/fenv_macros.h.
@lntue lntue added the libc label Apr 6, 2024
@llvmbot
Copy link
Member

llvmbot commented Apr 6, 2024

@llvm/issue-subscribers-libc

Author: None (lntue)

Context: https://github.com//pull/87017 https://github.com//pull/87598

Add a proxy header for fenv.h macro constants so that our implementations and tests will work nicely for both overlay and full build modes.

  • Add libc/hdr/fenv_macros.h that will include the system &lt;fenv.h&gt; in overlay mode or include libc/include/llvm-libc-macros/fenv-macros.h in full build mode. (See for instance libc/hdr/math_macros.h ).
  • Add its corresponding cmake target in libc/hdr/CMakeLists.txt.
  • Replacing as many #include &lt;fenv.h&gt; and cmake target dependency on libc.include.fenv as possible, and document where those inclusion cannot be removed yet (due to usage of types or functions defined in fenv.h)
  • Add hdr_fenv_macros target in utils/bazel/llvm-project-overlay/libc/BUILD.bazel.
  • Update dependencies to all targets that include hdr/fenv_macros.h.

@ghost
Copy link

ghost commented Apr 6, 2024

Can you please assign this to me? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants