-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[ClangCL] Add support for [[msvc::no_unique_address]] #83445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the 'pointer'! |
ayeteadoe
added a commit
to ayeteadoe/ladybird
that referenced
this issue
May 9, 2025
Clang-cl did not add support for [[msvc::no_unique_address]] until Clang 18 (llvm/llvm-project#83445). So this updates the minimum clang version to prevent developers from getting `-Wunknown-attributes` errors when building on Windows.
ayeteadoe
added a commit
to ayeteadoe/ladybird
that referenced
this issue
May 9, 2025
Clang-cl did not add support for [[msvc::no_unique_address]] until Clang 18 (llvm/llvm-project#83445). So this updates the minimum clang version to prevent developers from getting `-Wunknown-attributes` errors when building on Windows as a portion of the documentation states clang-17 is supported.
ayeteadoe
added a commit
to ayeteadoe/ladybird
that referenced
this issue
May 9, 2025
Clang-cl did not add support for [[msvc::no_unique_address]] until Clang 18 (llvm/llvm-project#83445). So this updates the minimum clang version to prevent developers from getting `-Wunknown-attributes` errors when building on Windows as a portion of the documentation states clang-17 is supported. I updated to the documentation to clang-19 as the main compiler install example uses that version and ideally there is consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently (v17.0.3) I get:
warning : unknown attribute 'no_unique_address' ignored [-Wunknown-attributes]
even with the msvc:: prefix one (which is supposed to work).The text was updated successfully, but these errors were encountered: