Skip to content

[ClangCL] Add support for [[msvc::no_unique_address]] #83445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
psiha opened this issue Feb 29, 2024 · 2 comments
Closed

[ClangCL] Add support for [[msvc::no_unique_address]] #83445

psiha opened this issue Feb 29, 2024 · 2 comments
Labels
clang-cl `clang-cl` driver. Don't use for other compiler parts duplicate Resolved as duplicate

Comments

@psiha
Copy link

psiha commented Feb 29, 2024

Currently (v17.0.3) I get: warning : unknown attribute 'no_unique_address' ignored [-Wunknown-attributes] even with the msvc:: prefix one (which is supposed to work).
@EugeneZelenko EugeneZelenko added clang-cl `clang-cl` driver. Don't use for other compiler parts and removed new issue labels Feb 29, 2024
@frederick-vs-ja
Copy link
Contributor

Duplicate of #49358.

I believe this is already fixed in Clang 18 by #65675 (also #67199).

@psiha
Copy link
Author

psiha commented Mar 2, 2024

Thanks for the 'pointer'!

@psiha psiha closed this as completed Mar 2, 2024
@EugeneZelenko EugeneZelenko added the duplicate Resolved as duplicate label Mar 2, 2024
@EugeneZelenko EugeneZelenko closed this as not planned Won't fix, can't repro, duplicate, stale Mar 2, 2024
ayeteadoe added a commit to ayeteadoe/ladybird that referenced this issue May 9, 2025
@ayeteadoe
Documentation: Update clang version in BuildInstructionsLadybird.md
f81b60b 
Clang-cl did not add support for [[msvc::no_unique_address]] until
Clang 18 (llvm/llvm-project#83445). So this
updates the minimum clang version to prevent developers from getting
`-Wunknown-attributes` errors when building on Windows.
ayeteadoe added a commit to ayeteadoe/ladybird that referenced this issue May 9, 2025
@ayeteadoe
Documentation: Update clang version in BuildInstructionsLadybird.md
93aee9c 
Clang-cl did not add support for [[msvc::no_unique_address]] until
Clang 18 (llvm/llvm-project#83445). So this
updates the minimum clang version to prevent developers from getting
`-Wunknown-attributes` errors when building on Windows as a portion
of the documentation states clang-17 is supported.
ayeteadoe added a commit to ayeteadoe/ladybird that referenced this issue May 9, 2025
@ayeteadoe
Documentation: Update clang version in BuildInstructionsLadybird.md
6dd8148 
Clang-cl did not add support for [[msvc::no_unique_address]] until
Clang 18 (llvm/llvm-project#83445). So this
updates the minimum clang version to prevent developers from getting
`-Wunknown-attributes` errors when building on Windows as a portion
of the documentation states clang-17 is supported. I updated to the
documentation to clang-19 as the main compiler install example uses
that version and ideally there is consistency.
@ayeteadoe ayeteadoe mentioned this issue May 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clang-cl `clang-cl` driver. Don't use for other compiler parts duplicate Resolved as duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@psiha @EugeneZelenko @frederick-vs-ja