Skip to content

[libc] Update preprocessor definitions for type detection #83182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 of 4 tasks
gchatelet opened this issue Feb 27, 2024 · 2 comments
Open
3 of 4 tasks

[libc] Update preprocessor definitions for type detection #83182

gchatelet opened this issue Feb 27, 2024 · 2 comments
Assignees
@gchatelet
Labels
libc metabug Issue to collect references to a group of similar or related issues.

Comments

@gchatelet
Copy link
Contributor

gchatelet commented Feb 27, 2024 •
edited
Loading

This is to track the items in #81870 (comment)

i.e.,
@gchatelet gchatelet added the libc label Feb 27, 2024
@gchatelet gchatelet self-assigned this Feb 27, 2024
@gchatelet
Copy link
Contributor Author

FYI @nickdesaulniers

@llvmbot
Copy link
Member

llvmbot commented Feb 27, 2024

@llvm/issue-subscribers-libc

Author: Guillaume Chatelet (gchatelet)

This is to track the items in https://github.com//pull/81870#issuecomment-1948099726

i.e.,

  • Rename float.h into types.h
  • Rename all #define in this file to LIBC_TYPES_HAS_...
    LIBC_TYPES_HAS_INT64
    LIBC_TYPES_HAS_FLOAT16
    LIBC_TYPES_HAS_FLOAT128
  • Don't expose how the type is provided and use float16 or float128 solely (i.e. no LIBC_COMPILER_HAS_FLOAT128_EXTENSION nor LIBC_COMPILER_HAS_C23_FLOAT128). Added benefit of not defining LIBC_COMPILER_... outside of the compiler.h file.
  • Update the documentation

@gchatelet gchatelet mentioned this issue Feb 27, 2024
Closed
@EugeneZelenko EugeneZelenko added the metabug Issue to collect references to a group of similar or related issues. label Feb 27, 2024
@gchatelet gchatelet changed the title Update preprocessor definitions for type detection [libc] Update preprocessor definitions for type detection Feb 27, 2024
This was referenced Feb 29, 2024
Merged
Merged
Merged
gchatelet added a commit that referenced this issue Feb 29, 2024
@gchatelet
[libc][NFC] Rename LIBC_COMPILER_HAS_C23_FLOAT16 to `LIBC_TYPES_HAS…
22f5e30 
…_FLOAT16` (#83396)

Umbrella bug #83182
gchatelet added a commit that referenced this issue Feb 29, 2024
@gchatelet
[libc][NFC] Rename LIBC_COMPILER_HAS_FLOAT128 to `LIBC_TYPES_HAS_FL…
75fb825 
…OAT128` (#83395)

Umbrella bug #83182
This was referenced Feb 29, 2024
Merged
Merged
gchatelet added a commit that referenced this issue Mar 4, 2024
@gchatelet
[libc][NFC] Rename LIBC_LONG_DOUBLE_IS_ macros (#83399)
f7d4236 
Umbrella bug #83182
gchatelet added a commit that referenced this issue Mar 4, 2024
@gchatelet
[libc][NFC] Don't expose how float16 and float128 types are provi…
07f8efa 
…ded (#83818)

Umbrella bug #83182
gchatelet added a commit to gchatelet/llvm-project that referenced this issue Mar 6, 2024
@gchatelet
[libc] Provide LIBC_TYPES_HAS_INT128
dd143c5 
Umbrella bug llvm#83182
@gchatelet gchatelet mentioned this issue Mar 6, 2024
Merged
gchatelet added a commit that referenced this issue Mar 8, 2024
@gchatelet
[libc] Provide LIBC_TYPES_HAS_INT128 (#84149)
23c397c 
Umbrella bug #83182
gchatelet added a commit that referenced this issue Mar 9, 2024
@gchatelet
[libc] Provide LIBC_TYPES_HAS_INT64 (#83441)
a84e66a 
Umbrella bug #83182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gchatelet gchatelet

Labels
libc metabug Issue to collect references to a group of similar or related issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gchatelet @EugeneZelenko @llvmbot