Windows `github-pull-request` pre-merge CI fails with "OSError: [Errno 22] Invalid argument" on various tests

[rengolin]

The basic github-pull-request CI check fails for FIR tests on Windows on unrelated changes (ex. #75955).

Unresolved Tests (4):
  Flang :: Lower/OpenMP/FIR/declare-target-implicit-func-and-subr-cap-enter.f90
  Flang :: Lower/OpenMP/FIR/declare-target-implicit-func-and-subr-cap.f90
  Flang :: Lower/OpenMP/declare-target-implicit-func-and-subr-cap-enter.f90
  Flang :: Lower/OpenMP/declare-target-implicit-func-and-subr-cap.f90

Example:

UNRESOLVED: Flang :: Lower/OpenMP/FIR/declare-target-implicit-func-and-subr-cap-enter.f90 (785 of 2469)
******************** TEST 'Flang :: Lower/OpenMP/FIR/declare-target-implicit-func-and-subr-cap-enter.f90' FAILED ********************
Exception during script execution:
Traceback (most recent call last):
  File "C:\ws\src\llvm\utils\lit\lit\worker.py", line 76, in _execute_test_handle_errors
    result = test.config.test_format.execute(test, lit_config)
  File "C:\ws\src\llvm\utils\lit\lit\formats\shtest.py", line 29, in execute
    return lit.TestRunner.executeShTest(
  File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2257, in executeShTest
    parsed = parseIntegratedTestScript(test, require_script=not script)
  File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2119, in parseIntegratedTestScript
    parsed = _parseKeywords(
  File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2058, in _parseKeywords
    for line_number, command_type, ln in parseIntegratedTestScriptCommands(
  File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 1280, in parseIntegratedTestScriptCommands
    f = open(source_path, "rb")
OSError: [Errno 22] Invalid argument: 'C:\\ws\\src\\flang\\test\\Lower\\OpenMP\\FIR\\declare-target-implicit-func-and-subr-cap-enter.f90'

If these tests are flaky, the should not be enabled by default on general CI pre-merge tests.

[llvmbot]

@llvm/issue-subscribers-infrastructure

Author: Renato Golin (rengolin)

The basic `github-pull-request` CI check [fails](https://buildkite.com/llvm-project/github-pull-requests/builds/26594#018cd5cd-2449-4e92-ba57-d2b15c95eefe/404-10521) for FIR tests on Windows on unrelated changes (ex. #75955).

Unresolved Tests (4):
  Flang :: Lower/OpenMP/FIR/declare-target-implicit-func-and-subr-cap-enter.f90
  Flang :: Lower/OpenMP/FIR/declare-target-implicit-func-and-subr-cap.f90
  Flang :: Lower/OpenMP/declare-target-implicit-func-and-subr-cap-enter.f90
  Flang :: Lower/OpenMP/declare-target-implicit-func-and-subr-cap.f90

Example:

UNRESOLVED: Flang :: Lower/OpenMP/FIR/declare-target-implicit-func-and-subr-cap-enter.f90 (785 of 2469)
******************** TEST 'Flang :: Lower/OpenMP/FIR/declare-target-implicit-func-and-subr-cap-enter.f90' FAILED ********************
Exception during script execution:
Traceback (most recent call last):
  File "C:\ws\src\llvm\utils\lit\lit\worker.py", line 76, in _execute_test_handle_errors
    result = test.config.test_format.execute(test, lit_config)
  File "C:\ws\src\llvm\utils\lit\lit\formats\shtest.py", line 29, in execute
    return lit.TestRunner.executeShTest(
  File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2257, in executeShTest
    parsed = parseIntegratedTestScript(test, require_script=not script)
  File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2119, in parseIntegratedTestScript
    parsed = _parseKeywords(
  File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2058, in _parseKeywords
    for line_number, command_type, ln in parseIntegratedTestScriptCommands(
  File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 1280, in parseIntegratedTestScriptCommands
    f = open(source_path, "rb")
OSError: [Errno 22] Invalid argument: 'C:\\ws\\src\\flang\\test\\Lower\\OpenMP\\FIR\\declare-target-implicit-func-and-subr-cap-enter.f90'

If these tests are flaky, the should not be enabled by default on general CI pre-merge tests.

[rengolin]

@kiranchandramohan @RichBarton-Arm

[joker-eph]

It's not clear to me that there is flakiness involved: do you see some runs passing?

The error seems to be lit failing to open these files:

  File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 1280, in parseIntegratedTestScriptCommands
    f = open(source_path, "rb")
OSError: [Errno 22] Invalid argument: 'C:\\ws\\src\\flang\\test\\Lower\\OpenMP\\FIR\\declare-target-implicit-func-and-subr-cap-enter.f90'

But I'm struggling to see what's special about these files that makes them different? (the path does not seem like it would exceed some length limitation for example)

[rengolin]

It's not clear to me that there is flakiness involved: do you see some runs passing?

Not really, I'm just assuming someone have seen those tests passing before... At the very least when this code was introduced and the PR had the exact same builder on it.

But these tests were added 6 months ago, so surely, they have passed before? Or maybe someone turned on the build recently? Still would have seen them in the PR that enabled them?

[Hardcode84]

My other PR, rebased on the same main sha #76108 had passed successfully

[joker-eph]

Many tests have OSError: [Errno 22] Invalid argument: here: https://buildkite.com/llvm-project/github-pull-requests/builds/26673#018cd6d2-932a-43bc-b481-de5dfa191c1d

Seems like a bot issue to me.

[llvmbot]

@llvm/issue-subscribers-infrastructure

Author: Renato Golin (rengolin)

The basic `github-pull-request` CI check [fails](https://buildkite.com/llvm-project/github-pull-requests/builds/26594#018cd5cd-2449-4e92-ba57-d2b15c95eefe/404-10521) for FIR tests on Windows on unrelated changes (ex. #75955).

Unresolved Tests (4):
  Flang :: Lower/OpenMP/FIR/declare-target-implicit-func-and-subr-cap-enter.f90
  Flang :: Lower/OpenMP/FIR/declare-target-implicit-func-and-subr-cap.f90
  Flang :: Lower/OpenMP/declare-target-implicit-func-and-subr-cap-enter.f90
  Flang :: Lower/OpenMP/declare-target-implicit-func-and-subr-cap.f90

Example:

UNRESOLVED: Flang :: Lower/OpenMP/FIR/declare-target-implicit-func-and-subr-cap-enter.f90 (785 of 2469)
******************** TEST 'Flang :: Lower/OpenMP/FIR/declare-target-implicit-func-and-subr-cap-enter.f90' FAILED ********************
Exception during script execution:
Traceback (most recent call last):
  File "C:\ws\src\llvm\utils\lit\lit\worker.py", line 76, in _execute_test_handle_errors
    result = test.config.test_format.execute(test, lit_config)
  File "C:\ws\src\llvm\utils\lit\lit\formats\shtest.py", line 29, in execute
    return lit.TestRunner.executeShTest(
  File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2257, in executeShTest
    parsed = parseIntegratedTestScript(test, require_script=not script)
  File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2119, in parseIntegratedTestScript
    parsed = _parseKeywords(
  File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2058, in _parseKeywords
    for line_number, command_type, ln in parseIntegratedTestScriptCommands(
  File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 1280, in parseIntegratedTestScriptCommands
    f = open(source_path, "rb")
OSError: [Errno 22] Invalid argument: 'C:\\ws\\src\\flang\\test\\Lower\\OpenMP\\FIR\\declare-target-implicit-func-and-subr-cap-enter.f90'

If these tests are flaky, the should not be enabled by default on general CI pre-merge tests.