Skip to content

[HLSL] implement frac intrinsic #70099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #30
llvm-beanz opened this issue Oct 24, 2023 · 0 comments · Fixed by #83465
Closed
Tracked by #30

[HLSL] implement frac intrinsic #70099

llvm-beanz opened this issue Oct 24, 2023 · 0 comments · Fixed by #83465
Assignees
Labels
backend:DirectX HLSL HLSL Language Support

Comments

@llvm-beanz
Copy link
Collaborator

Implement hlsl frac intrinsic:

https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-frac

@llvm-beanz llvm-beanz converted this from a draft issue Oct 24, 2023
@llvm-beanz llvm-beanz added the HLSL HLSL Language Support label Oct 24, 2023
farzonl added a commit to farzonl/llvm-project that referenced this issue Feb 28, 2024
This change implements the frontend  for llvm#70099
Builtins.td           - add the frac builtin
CGBuiltin.cpp         - add the builtin to DirectX intrinsic mapping
hlsl_intrinsics.h     - add the frac api
SemaChecking.cpp      - add type checks for builtin
IntrinsicsDirectX.td  - add the frac intrinsic

The backend changes for this are going to be very simple:
llvm@f309a0e

They were not included because llvm/lib/Target/DirectX/DXIL.td is going
through a major refactor.
@davidcook-msft davidcook-msft self-assigned this Feb 29, 2024
python3kgae pushed a commit that referenced this issue Feb 29, 2024
This change implements the frontend  for #70099
Builtins.td           - add the frac builtin
CGBuiltin.cpp         - add the builtin to DirectX intrinsic mapping
hlsl_intrinsics.h     - add the frac api
SemaChecking.cpp      - add type checks for builtin
IntrinsicsDirectX.td  - add the frac intrinsic

The backend changes for this are going to be very simple:
f309a0e

They were not included because llvm/lib/Target/DirectX/DXIL.td is going
through a major refactor.
@farzonl farzonl assigned farzonl and unassigned davidcook-msft Mar 1, 2024
@farzonl farzonl moved this to Needs Review in HLSL Support Mar 1, 2024
farzonl added a commit that referenced this issue Mar 1, 2024
This change adds lowering for HLSL's frac intrinsic to DXIL.

This change should complete #70099
@farzonl farzonl moved this from Needs Review to Done in HLSL Support Mar 1, 2024
@farzonl farzonl linked a pull request Mar 12, 2024 that will close this issue
@farzonl farzonl closed this as completed Mar 12, 2024
@farzonl farzonl assigned bharadwajy and unassigned farzonl Mar 15, 2024
@farzonl farzonl moved this from Done to Active in HLSL Support Mar 15, 2024
@farzonl farzonl assigned farzonl and unassigned bharadwajy Mar 15, 2024
@farzonl farzonl moved this from Active to Done in HLSL Support Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:DirectX HLSL HLSL Language Support
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants