Skip to content

operator<=> not defined for __wrap_iter #62486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ojrosten opened this issue May 2, 2023 · 5 comments · Fixed by #99343
Closed

operator<=> not defined for __wrap_iter #62486

ojrosten opened this issue May 2, 2023 · 5 comments · Fixed by #99343
Assignees
@mordante
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Comments

@ojrosten
Copy link

ojrosten commented May 2, 2023

While it is possible to use three way comparison for iterators coming from e.g. std::array, this does not work for e.g. std::vector.

The culprit appears to be that oeprator<=> is not defined for the iterator wrapper used in the latter.

https://godbolt.org/z/fMdYvvz5Y
@EugeneZelenko EugeneZelenko added libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. and removed new issue labels May 2, 2023
@Long5hot
Copy link
Contributor

Long5hot commented May 5, 2023

Can work on this issue?

@Long5hot Long5hot self-assigned this Sep 21, 2023
@mordante
Copy link
Member

@Long5hot are you still working on a patch for this issue?

@Long5hot Long5hot removed their assignment Dec 27, 2023
@Long5hot
Copy link
Contributor

had to move on other things, so could not able to focus on this issue..

@mordante
Copy link
Member

had to move on other things, so could not able to focus on this issue..

No problem, thanks for the feedback.

mordante added a commit that referenced this issue Jul 17, 2024
@mordante
[libc++][spaceship] Implements X::iterator container requirements.
635c6ec 
This implements the requirements for the container iterator requirements for
array, deque, vector, and vector<bool>.

Implements:
- LWG3352 strong_equality isn't a thing

Implements parts of:
- P1614R2 The Mothership has Landed

Fixes: #62486
@mordante mordante mentioned this issue Jul 17, 2024
Merged
@mordante mordante self-assigned this Jul 17, 2024
@mordante
Copy link
Member

FYI This actually is not a bug, it was a feature we had not implemented yet. I just put up a patch for review.

mordante added a commit that referenced this issue Jul 17, 2024
@mordante
[libc++][spaceship] Implements X::iterator container requirements.
d0e8d06 
This implements the requirements for the container iterator requirements for
array, deque, vector, and vector<bool>.

Implements:
- LWG3352 strong_equality isn't a thing

Implements parts of:
- P1614R2 The Mothership has Landed

Fixes: #62486
mordante added a commit that referenced this issue Jul 17, 2024
@mordante
[libc++][spaceship] Implements X::iterator container requirements.
00df20a 
This implements the requirements for the container iterator requirements for
array, deque, vector, and vector<bool>.

Implements:
- LWG3352 strong_equality isn't a thing

Implements parts of:
- P1614R2 The Mothership has Landed

Fixes: #62486
mordante added a commit that referenced this issue Jul 20, 2024
@mordante
[libc++][spaceship] Implements X::iterator container requirements.
fcc71b5 
This implements the requirements for the container iterator requirements for
array, deque, vector, and vector<bool>.

Implements:
- LWG3352 strong_equality isn't a thing

Implements parts of:
- P1614R2 The Mothership has Landed

Fixes: #62486
mordante added a commit that referenced this issue Jul 24, 2024
@mordante
[libc++][spaceship] Implements X::iterator container requirements. (#…
8d3252a 
…99343)

This implements the requirements for the container iterator requirements
for array, deque, vector, and `vector<bool>`.

Implements:
- LWG3352 strong_equality isn't a thing

Implements parts of:
- P1614R2 The Mothership has Landed

Fixes: #62486
mordante added a commit to mordante/llvm-project that referenced this issue Jul 24, 2024
@mordante
[libc++][spaceship] Implements X::iterator container requirements. (l…
456668e 
…lvm#99343)

This implements the requirements for the container iterator requirements
for array, deque, vector, and `vector<bool>`.

Implements:
- LWG3352 strong_equality isn't a thing

Implements parts of:
- P1614R2 The Mothership has Landed

Fixes: llvm#62486
@mordante mordante mentioned this issue Jul 24, 2024
Merged
yuxuanchen1997 pushed a commit that referenced this issue Jul 25, 2024
@mordante @yuxuanchen1997
[libc++][spaceship] Implements X::iterator container requirements. (#…
ea84f51 
…99343)

Summary:
This implements the requirements for the container iterator requirements
for array, deque, vector, and `vector<bool>`.

Implements:
- LWG3352 strong_equality isn't a thing

Implements parts of:
- P1614R2 The Mothership has Landed

Fixes: #62486

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60250694
tru pushed a commit to mordante/llvm-project that referenced this issue Jul 26, 2024
@mordante @tru
[libc++][spaceship] Implements X::iterator container requirements. (l…
05446fb 
…lvm#99343)

This implements the requirements for the container iterator requirements
for array, deque, vector, and `vector<bool>`.

Implements:
- LWG3352 strong_equality isn't a thing

Implements parts of:
- P1614R2 The Mothership has Landed

Fixes: llvm#62486
blueboxd pushed a commit to blueboxd/libcxx that referenced this issue Apr 19, 2025
@mordante @copybara-github
[libc++][spaceship] Implements X::iterator container requirements. (#…
70fe604 
…99343)

This implements the requirements for the container iterator requirements
for array, deque, vector, and `vector<bool>`.

Implements:
- LWG3352 strong_equality isn't a thing

Implements parts of:
- P1614R2 The Mothership has Landed

Fixes: llvm/llvm-project#62486
NOKEYCHECK=True
GitOrigin-RevId: 8d3252a8987818171878a26e4298b4b5dbf2a7e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mordante mordante

Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[libc++][spaceship] Implements X::iterator container requirements. llvm/llvm-project
4 participants
@mordante @EugeneZelenko @ojrosten @Long5hot