[Attributor] Honor alloca address space also for Heap2Stack allocas #53858
Assignees
Labels
ipo
Interprocedural optimizations
openmp
release:backport
release:cherry-pick-failed
release:reviewed
Milestone
Comments
|
@llvm/issue-subscribers-openmp |
|
/cherry-pick 8ad39fb |
|
Failed to cherry-pick: 8ad39fb https://github.com/llvm/llvm-project/actions/runs/1855576025 Please manually backport the fix and push it to your github fork. Once this is done, please add a comment like this:
|
|
/cherry-pick 8ad39fb |
|
/branch llvmbot/llvm-project/issue53858 |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this issue
Feb 17, 2022
When we move an allocation from the heap to the stack we need to allocate it in the alloca AS and then cast the result. This also prevents us from inserting the alloca after the allocation call but rather right before. Fixes llvm#53858 (cherry picked from commit 8ad39fb)
|
/pull-request llvmbot#79 |
tstellar
pushed a commit
to llvmbot/llvm-project
that referenced
this issue
Feb 21, 2022
When we move an allocation from the heap to the stack we need to allocate it in the alloca AS and then cast the result. This also prevents us from inserting the alloca after the allocation call but rather right before. Fixes llvm#53858 (cherry picked from commit 8ad39fb)
jdoerfert
added a commit
to jdoerfert/llvm-project
that referenced
this issue
Mar 25, 2022
When we move an allocation from the heap to the stack we need to allocate it in the alloca AS and then cast the result. This also prevents us from inserting the alloca after the allocation call but rather right before. Fixes llvm#53858
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this issue
Oct 7, 2022
When we move an allocation from the heap to the stack we need to allocate it in the alloca AS and then cast the result. This also prevents us from inserting the alloca after the allocation call but rather right before. Fixes llvm/llvm-project#53858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The AMD gpu backend doesn't like AS0 allocas. We need to create them in the alloca AS instead. Causes OpenMP programs on AMD GPU to crash at compile time, sometimes with the weirdest assertions.
The text was updated successfully, but these errors were encountered: