Skip to content

Stale comments #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hexagonrecursion opened this issue Feb 4, 2020 · 2 comments
Closed

Stale comments #115

hexagonrecursion opened this issue Feb 4, 2020 · 2 comments
Assignees
@haoNoQ
Labels
clang:static analyzer

Comments

@hexagonrecursion
Copy link

There are a number of comments referencing GREngine and GRExprEngine, but as far as I can tell GREngine no longer exists. Should they be changed to reference ExprEngine?

llvm-project/clang/lib/StaticAnalyzer/Core/ExprEngine.cpp

Line 10 in 1132f87

// is built on GREngine, but provides the boilerplate to execute transfer

llvm-project/clang/lib/StaticAnalyzer/README.txt

Line 8 in 1132f87

engine (GRExprEngine.cpp and friends), and some static checkers

llvm-project/clang/test/Analysis/PR3991.m

Line 53 in a974b33

// GRExprEngine::Visit and GRExprEngine::VisitLValue have such expressions

llvm-project/clang/test/Analysis/misc-ps-eager-assume.m

Line 52 in a974b33

// 'recoverCastedSymbol()' (GRExprEngine.cpp) to test that we recover

@jdoerfert jdoerfert mentioned this issue Mar 14, 2020
Closed
@llvmbot
Copy link
Member

llvmbot commented Apr 12, 2022

@llvm/issue-subscribers-clang-static-analyzer

@haoNoQ
Copy link
Collaborator

haoNoQ commented Apr 12, 2022

Yes, definitely.

@haoNoQ haoNoQ self-assigned this Apr 12, 2022
@doocman doocman mentioned this issue Jun 5, 2022
Open
augusto2112 pushed a commit to augusto2112/llvm-project that referenced this issue Sep 9, 2022
@haoNoQ
[analyzer][NFC] Rename GREngine->CoreEngine, GRExprEngine->ExprEngine…
09b956e 
… in comments and txt files

fixes llvm#115

(cherry picked from commit 6ab69ef)
@TatyanaDoubts TatyanaDoubts mentioned this issue Nov 4, 2022
Closed
@Bouncner Bouncner mentioned this issue Jun 12, 2023
Closed
cuviper pushed a commit to cuviper/llvm-project that referenced this issue Aug 27, 2023
@nikic
[NewPM] Add missing LTO ArgPromotion pass (llvm#115)
429ff8c 
This is a followup to D96780 to add one more pass missing from the
NewPM LTO pipeline. The missing ArgPromotion run is inserted at
the same position as in the LegacyPM, resolving the already
present FIXME:
https://github.com/llvm/llvm-project/blob/16086d47c0d0cd08ffae8e69a69c88653e654d01/llvm/lib/Transforms/IPO/PassManagerBuilder.cpp#L1096-L1098

The compile-time impact is minimal with ~0.1% geomean regression
on CTMark.

Differential Revision: https://reviews.llvm.org/D108866

(cherry picked from commit b28c3b9)
@nilres nilres mentioned this issue May 28, 2024
Closed
mjklemm pushed a commit to mjklemm/llvm-project that referenced this issue Jul 11, 2024
@ergawy
[flang][OpenMP] Further handling of target ... do fixup logic (llvm…
e8b67b7 
…#115)

Cloning `hlfir.declare` ops during fix up can result in type mismatches.
For example, a `fir.ref<fir.array<...>>` variable is mapped a s
`fir.box<fir.array<...>>` which results in the fix up logic creating
invalid IR. This PR fixes the issue by avoiding cloning `hlfir.declare`
ops in the first place since they are specially handled during the
fix-up process.
pysuxing pushed a commit to pysuxing/llvm-project that referenced this issue Jul 17, 2024
@htyu @lanza
[ClR] Set optnone attribute for functions. (llvm#115)
4155a13 
Summary:
Setting the Optnone attribute for CIR functions and progating it all the
way down to LLVM IR for those not supposed to be optimized.
pysuxing pushed a commit to pysuxing/llvm-project that referenced this issue Jul 17, 2024
@htyu @lanza
[ClR] Set optnone attribute for functions. (llvm#115)
5a372f8 
Summary:
Setting the Optnone attribute for CIR functions and progating it all the
way down to LLVM IR for those not supposed to be optimized.
RevySR pushed a commit to revyos/llvm-project that referenced this issue Jul 27, 2024
@imkiva
[Clang][XTHeadVector] Fix __riscv_v_elen and __riscv_v_elen_fp (l…
180004b 
…lvm#115)
@usx95 usx95 mentioned this issue Sep 6, 2024
Closed
keryell pushed a commit to keryell/llvm-project that referenced this issue Oct 19, 2024
@htyu @lanza
[ClR] Set optnone attribute for functions. (llvm#115)
59fb653 
Summary:
Setting the Optnone attribute for CIR functions and progating it all the
way down to LLVM IR for those not supposed to be optimized.
xlauko pushed a commit to trailofbits/instafix-llvm that referenced this issue Mar 28, 2025
@htyu @xlauko
[ClR] Set optnone attribute for functions. (llvm#115)
9a43943 
Summary:
Setting the Optnone attribute for CIR functions and progating it all the
way down to LLVM IR for those not supposed to be optimized.
@piyushhingu piyushhingu mentioned this issue Apr 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haoNoQ haoNoQ

Labels
clang:static analyzer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@haoNoQ @RKSimon @hexagonrecursion @llvmbot