Skip to content

Extending LLDB to work on AIX #101657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DhruvSrivastavaX opened this issue Aug 2, 2024 · 4 comments
Closed

Extending LLDB to work on AIX #101657

DhruvSrivastavaX opened this issue Aug 2, 2024 · 4 comments
Labels
lldb platform:aix question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!

Comments

@DhruvSrivastavaX
Copy link
Contributor

DhruvSrivastavaX commented Aug 2, 2024 •
edited
Loading

Hi Community Members,

We have Implemented the necessary code changes required to run LLDB on AIX.

Since AIX wants to be the part of LLDB community, and want their feature enhancements to work with the Community
to extend support of LLDB to AIX as well, we would like to contribute changes required to run LLDB on AIX via a Pull Request.

Kindly let us know if we can. Once we raise the PR, also let us know if we can have a better design to the code changes from your experience, so that we can make it easy to maintain for you and AIX. We would like our code to be a part of the next release of the LLDB Project and actively involve in maintaining LLDB on AIX and the Community.

Thanks & Regards,
Dhruv Srivastava
IBM
@asl
Copy link
Collaborator

asl commented Aug 2, 2024 •
edited
Loading

You do not need a permission to open a PR provided that is follows LLVM's Contribution Guidelines: https://llvm.org/docs/Contributing.html#how-to-submit-a-patch

If you'd need to discuss something, you can always submit and RFC to LLVM Discourse

@asl asl closed this as completed Aug 2, 2024
@asl asl added the question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead! label Aug 2, 2024
@llvmbot
Copy link
Member

llvmbot commented Aug 2, 2024

@llvm/issue-subscribers-lldb

Author: None (Dhruv-Srivastava-IBM)

Hi Community Members,

We have Implemented the necessary code changes required to run LLDB on AIX.

Since AIX wants to be the part of LLDB community, and want their feature enhancements to work with the Community
to extend support of LLDB to AIX as well, we would like to contribute changes required to run LLDB on AIX via a Pull Request.

Kindly let us know if we can. Once we raise the PR, also let us know if we can have a better design to the code changes from your experience, so that we can make it easy to maintain for you and AIX. We would like our code to be a part of the next release of the LLDB Project and actively involve in maintaining LLDB on AIX and the Community.

Thanks & Regards,
Dhruv Srivastava
IBM

@DavidSpickett
Copy link
Collaborator

If you'd need to discuss something, you can always submit and RFC to LLVM Discourse

Yes, please start a thread in https://discourse.llvm.org/c/subprojects/lldb/8 going over what AIX is, your goals in doing this support, how it will be tested, who the code owners will be, link to some WIP changes and any other information you think will be helpful for us to understand the platform.

@DhruvSrivastavaX
Copy link
Contributor Author

Okay Thanks for the inputs.
I will start a conversation regarding the same on discourse and mention the details over there.

DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Aug 9, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
a2f162d
@DhruvSrivastavaX DhruvSrivastavaX mentioned this issue Aug 9, 2024
Draft
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Aug 12, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
d1e3ac5
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Aug 16, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
061180f
@DhruvSrivastavaX DhruvSrivastavaX mentioned this issue Aug 17, 2024
Merged
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Aug 20, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
b3b75da
DavidSpickett pushed a commit that referenced this issue Aug 20, 2024
@DhruvSrivastavaX
[lldb][AIX] 1. Avoid namespace collision on other platforms (#104679)
b804516 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:
1.  https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2.  #101657 

The complete changes for porting are present in this draft PR:
#102601

The changes on this PR are intended to avoid namespace collision for
certain typedefs between lldb and other platforms:
1. tid_t --> lldb::tid_t
2. offset_t --> lldb::offset_t
This was referenced Aug 21, 2024
Closed
Merged
DavidSpickett pushed a commit that referenced this issue Aug 22, 2024
@DhruvSrivastavaX
[lldb][AIX] Updating XCOFF,PPC entry in LLDB ArchSpec (#105523)
1b664fe 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. #101657 

The complete changes for porting are present in this draft PR:
#102601 

The changes in this PR are intended to update the Architecture entry for
LLDB with XCOFF,PPC.

1. Added new ArchitectureType `eArchTypeXCOFF`
2. Added a new `ArchDefinitionEntry g_xcoff_arch_entries[]`
3. Added a new case for `XCOFF in ArchSpec::SetArchitecture(..)`
4. Updated `ArchDefinition *g_arch_definitions[]`
Lakshmi-Surekha pushed a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Aug 23, 2024
Changes made after getting merge conflict while porting AIX code into…
ae7a76e 
… LLDB

Merge remote-tracking branch 'upstream/main' into llvmgh-101657
cjdb pushed a commit to cjdb/llvm-project that referenced this issue Aug 23, 2024
@DhruvSrivastavaX @cjdb
[lldb][AIX] Updating XCOFF,PPC entry in LLDB ArchSpec (llvm#105523)
f873b5f 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. llvm#101657 

The complete changes for porting are present in this draft PR:
llvm#102601 

The changes in this PR are intended to update the Architecture entry for
LLDB with XCOFF,PPC.

1. Added new ArchitectureType `eArchTypeXCOFF`
2. Added a new `ArchDefinitionEntry g_xcoff_arch_entries[]`
3. Added a new case for `XCOFF in ArchSpec::SetArchitecture(..)`
4. Updated `ArchDefinition *g_arch_definitions[]`
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Aug 30, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
094e590
@DhruvSrivastavaX DhruvSrivastavaX mentioned this issue Sep 1, 2024
Open
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Sep 4, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
f7fb892
@DhruvSrivastavaX DhruvSrivastavaX mentioned this issue Sep 10, 2024
Closed
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Sep 12, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
9c95e79
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue Sep 17, 2024
@DhruvSrivastavaX
Merge branch 'llvm:main' into llvmgh-101657
163e510
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 16, 2025
@DhruvSrivastavaX
Merge remote-tracking branch 'upstream/main' into llvmgh-101657
b3f3733
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this issue May 16, 2025
@DhruvSrivastavaX @github-actions
Automerge: [lldb][AIX] Adding NativeThreadAIX (#139537)
f05a543 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. llvm/llvm-project#101657
The complete changes for porting are present in this draft PR:
llvm/llvm-project#102601

**Description:**
Adding NativeThreadAIX base files,
to be integrated with already merged NativeProcessAIX.
DhruvSrivastavaX added a commit that referenced this issue May 16, 2025
@DhruvSrivastavaX
[lldb][AIX] Added 32-bit XCOFF Executable support (#139875)
c02e6ca 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. #101657
The complete changes for porting are present in this draft PR:
#102601

**Description:**
Adding support for XCOFF 32 bit file format as well in lldb, up to the
point where 64-bit support is implemented.
Added a new test case for the same. 
This is an incremental PR on top of the previous couple of XCOFF support
commits.
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 16, 2025
@DhruvSrivastavaX
Merge remote-tracking branch 'upstream/main' into llvmgh-101657
5dcc4aa
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this issue May 16, 2025
@DhruvSrivastavaX @github-actions
Automerge: [lldb][AIX] Added 32-bit XCOFF Executable support (#139875)
cb52e06 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. llvm/llvm-project#101657
The complete changes for porting are present in this draft PR:
llvm/llvm-project#102601

**Description:**
Adding support for XCOFF 32 bit file format as well in lldb, up to the
point where 64-bit support is implemented.
Added a new test case for the same.
This is an incremental PR on top of the previous couple of XCOFF support
commits.
ravindra-shinde2 added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 19, 2025
@ravindra-shinde2
Merge branch 'llvm:main' into llvmgh-101657
c2d7807
ravindra-shinde2 added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 20, 2025
@ravindra-shinde2
Merge branch 'llvm:main' into llvmgh-101657
a111502
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 20, 2025
@DhruvSrivastavaX
Merge remote-tracking branch 'origin/llvmgh-101657' into xcoff32-support
fc9eea1
ravindra-shinde2 added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 20, 2025
@ravindra-shinde2
Merge branch 'llvm:main' into llvmgh-101657
1071a2c
ravindra-shinde2 added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 21, 2025
@ravindra-shinde2
Merge branch 'llvm:main' into llvmgh-101657
c16ee8d
ravindra-shinde2 added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 22, 2025
@ravindra-shinde2
Merge branch 'llvm:main' into llvmgh-101657
f052c81
ravindra-shinde2 added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 23, 2025
@ravindra-shinde2
Merge branch 'llvm:main' into llvmgh-101657
950820a
ravindra-shinde2 added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 25, 2025
@ravindra-shinde2
Merge branch 'llvm:main' into llvmgh-101657
b45bc47
ravindra-shinde2 added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 26, 2025
@ravindra-shinde2
Merge branch 'llvm:main' into llvmgh-101657
8f4ecd2
ravindra-shinde2 added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 26, 2025
@ravindra-shinde2
Merge branch 'llvm:main' into llvmgh-101657
1f7c18a
@DhruvSrivastavaX DhruvSrivastavaX mentioned this issue May 27, 2025
Open
ravindra-shinde2 added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 27, 2025
@ravindra-shinde2
Merge branch 'llvm:main' into llvmgh-101657
d38bfbd
ravindra-shinde2 added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 28, 2025
@ravindra-shinde2
Merge branch 'llvm:main' into llvmgh-101657
85c8cae
ravindra-shinde2 added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 28, 2025
@ravindra-shinde2
Merge branch 'llvm:main' into llvmgh-101657
517c2e1
ravindra-shinde2 added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 29, 2025
@ravindra-shinde2
Merge branch 'llvm:main' into llvmgh-101657
3fee26a
DhruvSrivastavaX pushed a commit that referenced this issue May 29, 2025
@HemangGadhavi
[lldb][AIX] get host info for AIX (cont..) (#138687)
f4e1ec5 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. #101657
The complete changes for porting are present in this draft PR:
#102601

- Added testcase for `GetProgramFileSpec()` & `FindProcesses()`
- Added changes to get the host information for AIX (info like
FindProcessesImpl() GetProgramFileSpec()),
continue from the PR #134354
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this issue May 29, 2025
@HemangGadhavi @github-actions
Automerge: [lldb][AIX] get host info for AIX (cont..) (#138687)
ea93910 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. llvm/llvm-project#101657
The complete changes for porting are present in this draft PR:
llvm/llvm-project#102601

- Added testcase for `GetProgramFileSpec()` & `FindProcesses()`
- Added changes to get the host information for AIX (info like
FindProcessesImpl() GetProgramFileSpec()),
continue from the PR llvm/llvm-project#134354
HemangGadhavi added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 29, 2025
@HemangGadhavi
Merge remote-tracking branch 'upstream/main' into llvmgh-101657
b3ce83c
HemangGadhavi added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 29, 2025
@HemangGadhavi
Merge remote-tracking branch 'upstream/main' into llvmgh-101657
0e86da4
HemangGadhavi added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 29, 2025
@HemangGadhavi
Revert "Merge remote-tracking branch 'upstream/main' into llvmgh-101657"
e3a3a8b 
This reverts commit 0e86da4, reversing
changes made to 1071a2c.
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 29, 2025
@DhruvSrivastavaX
Merge remote-tracking branch 'origin/llvmgh-101657' into xcoff-new-im…
bf7d3f6 
…plementation
svkeerthy pushed a commit that referenced this issue May 29, 2025
@HemangGadhavi @svkeerthy
[lldb][AIX] get host info for AIX (cont..) (#138687)
b46b9fe 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. #101657
The complete changes for porting are present in this draft PR:
#102601

- Added testcase for `GetProgramFileSpec()` & `FindProcesses()`
- Added changes to get the host information for AIX (info like
FindProcessesImpl() GetProgramFileSpec()),
continue from the PR #134354
google-yfyang pushed a commit to google-yfyang/llvm-project that referenced this issue May 29, 2025
@HemangGadhavi @google-yfyang
[lldb][AIX] get host info for AIX (cont..) (llvm#138687)
108831e 
This PR is in reference to porting LLDB on AIX.

Link to discussions on llvm discourse and github:

1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. llvm#101657
The complete changes for porting are present in this draft PR:
llvm#102601

- Added testcase for `GetProgramFileSpec()` & `FindProcesses()`
- Added changes to get the host information for AIX (info like
FindProcessesImpl() GetProgramFileSpec()),
continue from the PR llvm#134354
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 30, 2025
@DhruvSrivastavaX
Merge remote-tracking branch 'upstream/main' into llvmgh-101657
e352f32
DhruvSrivastavaX added a commit to DhruvSrivastavaX/lldb-for-aix that referenced this issue May 30, 2025
@DhruvSrivastavaX
Merge remote-tracking branch 'origin/llvmgh-101657' into xcoff-new-im…
65b65ec 
…plementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lldb platform:aix question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@asl @DavidSpickett @EugeneZelenko @llvmbot @DhruvSrivastavaX