Skip to content

Commit fcd090c

Browse files
committed
Address review comments
1 parent c923eb1 commit fcd090c

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

clang/lib/Driver/ToolChains/Clang.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1484,8 +1484,11 @@ void AddUnalignedAccessWarning(ArgStringList &CmdArgs) {
14841484
}
14851485
}
14861486

1487+
// Each combination of options here forms a signing schema, and in most cases
1488+
// each signing schema is its own incompatible ABI. The default values of the
1489+
// options represent the default signing schema.
14871490
static void handlePAuthABIOption(const ArgList &DriverArgs,
1488-
ArgStringList &CC1Args, const Driver &D) {
1491+
ArgStringList &CC1Args) {
14891492
if (!DriverArgs.hasArg(options::OPT_fptrauth_intrinsics,
14901493
options::OPT_fno_ptrauth_intrinsics))
14911494
CC1Args.push_back("-fptrauth-intrinsics");
@@ -1579,7 +1582,7 @@ static void CollectARMPACBTIOptions(const ToolChain &TC, const ArgList &Args,
15791582
IndirectBranches = PBP.BranchTargetEnforcement;
15801583
GuardedControlStack = PBP.GuardedControlStack;
15811584
if (isAArch64 && PBP.HasPauthABI)
1582-
handlePAuthABIOption(Args, CmdArgs, D);
1585+
handlePAuthABIOption(Args, CmdArgs);
15831586
}
15841587

15851588
CmdArgs.push_back(

0 commit comments

Comments
 (0)