Skip to content

Commit f0c920f

Browse files
authored
[libc++][hardening] XFAIL tests with HWASAN (#78866)
Follow up to #78862 These tests control hardening mode with `ADDITIONAL_COMPILE_FLAGS`, and always set modes which use on TRAP. So we don't need to check `libcpp-hardening-mode=fast`, and they must always fail with the current HWASAN implementation.
1 parent 61d0989 commit f0c920f

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

libcxx/test/libcxx/assertions/modes/enabling_assertions_enables_extensive_mode.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
// debug mode).
1717
// XFAIL: libcpp-hardening-mode=debug && availability-verbose_abort-missing
1818
// HWASAN replaces TRAP with abort or error exit code.
19-
// XFAIL: libcpp-hardening-mode=fast && hwasan
19+
// XFAIL: hwasan
2020
// Note that GCC doesn't support `-Wno-macro-redefined`.
2121
// ADDITIONAL_COMPILE_FLAGS: -U_LIBCPP_HARDENING_MODE -D_LIBCPP_ENABLE_ASSERTIONS=1
2222

libcxx/test/libcxx/assertions/modes/override_with_extensive_mode.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
// debug mode).
1515
// XFAIL: libcpp-hardening-mode=debug && availability-verbose_abort-missing
1616
// HWASAN replaces TRAP with abort or error exit code.
17-
// XFAIL: libcpp-hardening-mode=fast && hwasan
17+
// XFAIL: hwasan
1818
// ADDITIONAL_COMPILE_FLAGS: -U_LIBCPP_HARDENING_MODE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE
1919

2020
#include <cassert>

libcxx/test/libcxx/assertions/modes/override_with_fast_mode.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
// debug mode).
1515
// XFAIL: libcpp-hardening-mode=debug && availability-verbose_abort-missing
1616
// HWASAN replaces TRAP with abort or error exit code.
17-
// XFAIL: libcpp-hardening-mode=fast && hwasan
17+
// XFAIL: hwasan
1818
// ADDITIONAL_COMPILE_FLAGS: -U_LIBCPP_HARDENING_MODE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_FAST
1919

2020
#include <cassert>

0 commit comments

Comments
 (0)