update

matthias-springer · matthias-springer · commit ed5a2dccbe3a · 2024-08-17T12:39:31.000+02:00
diff --git a/mlir/lib/Conversion/ReconcileUnrealizedCasts/ReconcileUnrealizedCasts.cpp b/mlir/lib/Conversion/ReconcileUnrealizedCasts/ReconcileUnrealizedCasts.cpp
@@ -42,7 +42,7 @@ struct ReconcileUnrealizedCasts
   void runOnOperation() override {
     SmallVector<UnrealizedConversionCastOp> ops;
     getOperation()->walk(
-        [&](UnrealizedConversionCastOp castOp) { ops.insert(castOp); });
+        [&](UnrealizedConversionCastOp castOp) { ops.push_back(castOp); });
     reconcileUnrealizedCasts(ops);
   }
 };
diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -2875,7 +2875,7 @@ LogicalResult OperationConverter::legalizeErasedResult(
 
 void mlir::reconcileUnrealizedCasts(
     ArrayRef<UnrealizedConversionCastOp> castOps,
-    SmallVector<UnrealizedConversionCastOp> *remainingCastOps) {
+    SmallVectorImpl<UnrealizedConversionCastOp> *remainingCastOps) {
   SetVector<UnrealizedConversionCastOp> worklist(castOps.begin(),
                                                  castOps.end());
   // This set is maintained only if `remainingCastOps` is provided.

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ struct ReconcileUnrealizedCasts`
`42`	`42`	`void runOnOperation() override {`
`43`	`43`	`SmallVector<UnrealizedConversionCastOp> ops;`
`44`	`44`	`getOperation()->walk(`
`45`		`- [&](UnrealizedConversionCastOp castOp) { ops.insert(castOp); });`
	`45`	`+ [&](UnrealizedConversionCastOp castOp) { ops.push_back(castOp); });`
`46`	`46`	`reconcileUnrealizedCasts(ops);`
`47`	`47`	`}`
`48`	`48`	`};`