Skip to content

Commit dbb9fae

Browse files
Re-apply '[AArch64] Enable "sink-and-fold" in MachineSink by default (#67432)'
This re-applies commit a9d0ab2, which was reverted by 8abb2ac. The issue was fixed by 7510f32
1 parent afdb18d commit dbb9fae

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

llvm/lib/Target/AArch64/AArch64TargetMachine.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ static cl::opt<bool> EnableGISelLoadStoreOptPostLegal(
200200
static cl::opt<bool>
201201
EnableSinkFold("aarch64-enable-sink-fold",
202202
cl::desc("Enable sinking and folding of instruction copies"),
203-
cl::init(false), cl::Hidden);
203+
cl::init(true), cl::Hidden);
204204

205205
extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeAArch64Target() {
206206
// Register the target.

llvm/test/CodeGen/AArch64/machine-sink-cache-invalidation.ll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@ define i32 @nsis_BZ2_bzDecompress(ptr %pos.i, i1 %cmp661.not3117.i, i1 %exitcond
2222
; CHECK-NEXT: // in Loop: Header=BB0_2 Depth=1
2323
; CHECK-NEXT: mov x9, xzr
2424
; CHECK-NEXT: ldrb w9, [x9]
25-
; CHECK-NEXT: add x9, x0, x9
26-
; CHECK-NEXT: strb wzr, [x9]
25+
; CHECK-NEXT: strb wzr, [x0, x9]
2726
; CHECK-NEXT: b .LBB0_1
2827
; CHECK-NEXT: .LBB0_4: // %for.end677.i
2928
; CHECK-NEXT: mov w0, wzr

llvm/test/CodeGen/AArch64/sink-and-fold.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
2-
; RUN: llc -aarch64-enable-sink-fold=true < %s | FileCheck %s
2+
; RUN: llc < %s | FileCheck %s
33
target triple = "aarch64-linux"
44

55
declare i32 @use(...)

0 commit comments

Comments
 (0)