Skip to content

Commit c9733b8

Browse files
authored
[libomptarget][NFC]Rename targetDataMapper to targetDat in interface.cpp (#65915)
In omptarget.cpp, there is a targetDataMapper which does mapper related operations. In interface.cpp, targetDataMapper function template is simply needed for handling TargetAsyncInfoTy. Thus it is better to name it as simple as targetData similar to targetKernel.
1 parent d47cf2b commit c9733b8

File tree

2 files changed

+18
-19
lines changed

2 files changed

+18
-19
lines changed

openmp/libomptarget/src/interface.cpp

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,11 @@ EXTERN void __tgt_unregister_lib(__tgt_bin_desc *Desc) {
7474

7575
template <typename TargetAsyncInfoTy>
7676
static inline void
77-
targetDataMapper(ident_t *Loc, int64_t DeviceId, int32_t ArgNum,
78-
void **ArgsBase, void **Args, int64_t *ArgSizes,
79-
int64_t *ArgTypes, map_var_info_t *ArgNames, void **ArgMappers,
80-
TargetDataFuncPtrTy TargetDataFunction,
81-
const char *RegionTypeMsg, const char *RegionName) {
77+
targetData(ident_t *Loc, int64_t DeviceId, int32_t ArgNum, void **ArgsBase,
78+
void **Args, int64_t *ArgSizes, int64_t *ArgTypes,
79+
map_var_info_t *ArgNames, void **ArgMappers,
80+
TargetDataFuncPtrTy TargetDataFunction, const char *RegionTypeMsg,
81+
const char *RegionName) {
8282
static_assert(std::is_convertible_v<TargetAsyncInfoTy, AsyncInfoTy>,
8383
"TargetAsyncInfoTy must be convertible to AsyncInfoTy.");
8484

@@ -113,7 +113,7 @@ targetDataMapper(ident_t *Loc, int64_t DeviceId, int32_t ArgNum,
113113
TargetDataFunction == targetDataEnd ||
114114
TargetDataFunction == targetDataUpdate) &&
115115
"Encountered unexpected TargetDataFunction during "
116-
"execution of targetDataMapper");
116+
"execution of targetData");
117117
auto CallbackFunctions =
118118
(TargetDataFunction == targetDataBegin)
119119
? RegionInterface.getCallbacks<ompt_target_enter_data>()
@@ -144,10 +144,10 @@ EXTERN void __tgt_target_data_begin_mapper(ident_t *Loc, int64_t DeviceId,
144144
map_var_info_t *ArgNames,
145145
void **ArgMappers) {
146146

147-
targetDataMapper<AsyncInfoTy>(Loc, DeviceId, ArgNum, ArgsBase, Args, ArgSizes,
148-
ArgTypes, ArgNames, ArgMappers, targetDataBegin,
149-
"Entering OpenMP data region with being_mapper",
150-
"begin");
147+
targetData<AsyncInfoTy>(Loc, DeviceId, ArgNum, ArgsBase, Args, ArgSizes,
148+
ArgTypes, ArgNames, ArgMappers, targetDataBegin,
149+
"Entering OpenMP data region with being_mapper",
150+
"begin");
151151
}
152152

153153
EXTERN void __tgt_target_data_begin_nowait_mapper(
@@ -156,7 +156,7 @@ EXTERN void __tgt_target_data_begin_nowait_mapper(
156156
void **ArgMappers, int32_t DepNum, void *DepList, int32_t NoAliasDepNum,
157157
void *NoAliasDepList) {
158158

159-
targetDataMapper<TaskAsyncInfoWrapperTy>(
159+
targetData<TaskAsyncInfoWrapperTy>(
160160
Loc, DeviceId, ArgNum, ArgsBase, Args, ArgSizes, ArgTypes, ArgNames,
161161
ArgMappers, targetDataBegin,
162162
"Entering OpenMP data region with being_nowait_mapper", "begin");
@@ -172,10 +172,9 @@ EXTERN void __tgt_target_data_end_mapper(ident_t *Loc, int64_t DeviceId,
172172
map_var_info_t *ArgNames,
173173
void **ArgMappers) {
174174

175-
targetDataMapper<AsyncInfoTy>(Loc, DeviceId, ArgNum, ArgsBase, Args, ArgSizes,
176-
ArgTypes, ArgNames, ArgMappers, targetDataEnd,
177-
"Exiting OpenMP data region with end_mapper",
178-
"end");
175+
targetData<AsyncInfoTy>(Loc, DeviceId, ArgNum, ArgsBase, Args, ArgSizes,
176+
ArgTypes, ArgNames, ArgMappers, targetDataEnd,
177+
"Exiting OpenMP data region with end_mapper", "end");
179178
}
180179

181180
EXTERN void __tgt_target_data_end_nowait_mapper(
@@ -184,7 +183,7 @@ EXTERN void __tgt_target_data_end_nowait_mapper(
184183
void **ArgMappers, int32_t DepNum, void *DepList, int32_t NoAliasDepNum,
185184
void *NoAliasDepList) {
186185

187-
targetDataMapper<TaskAsyncInfoWrapperTy>(
186+
targetData<TaskAsyncInfoWrapperTy>(
188187
Loc, DeviceId, ArgNum, ArgsBase, Args, ArgSizes, ArgTypes, ArgNames,
189188
ArgMappers, targetDataEnd,
190189
"Exiting OpenMP data region with end_nowait_mapper", "end");
@@ -197,7 +196,7 @@ EXTERN void __tgt_target_data_update_mapper(ident_t *Loc, int64_t DeviceId,
197196
map_var_info_t *ArgNames,
198197
void **ArgMappers) {
199198

200-
targetDataMapper<AsyncInfoTy>(
199+
targetData<AsyncInfoTy>(
201200
Loc, DeviceId, ArgNum, ArgsBase, Args, ArgSizes, ArgTypes, ArgNames,
202201
ArgMappers, targetDataUpdate,
203202
"Updating data within the OpenMP data region with update_mapper",
@@ -209,7 +208,7 @@ EXTERN void __tgt_target_data_update_nowait_mapper(
209208
void **Args, int64_t *ArgSizes, int64_t *ArgTypes, map_var_info_t *ArgNames,
210209
void **ArgMappers, int32_t DepNum, void *DepList, int32_t NoAliasDepNum,
211210
void *NoAliasDepList) {
212-
targetDataMapper<TaskAsyncInfoWrapperTy>(
211+
targetData<TaskAsyncInfoWrapperTy>(
213212
Loc, DeviceId, ArgNum, ArgsBase, Args, ArgSizes, ArgTypes, ArgNames,
214213
ArgMappers, targetDataUpdate,
215214
"Updating data within the OpenMP data region with update_nowait_mapper",

openmp/libomptarget/src/private.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,6 +438,6 @@ class ExponentialBackoff {
438438
#define TIMESCOPE()
439439
#define TIMESCOPE_WITH_IDENT(IDENT)
440440
#define TIMESCOPE_WITH_NAME_AND_IDENT(NAME, IDENT)
441-
#define TIMESCOPE_WITH_RTM_AND_IDENT(RegionTypeMsg, IDENT)
441+
#define TIMESCOPE_WITH_RTM_AND_IDENT(RegionTypeMsg, IDENT)
442442

443443
#endif

0 commit comments

Comments
 (0)