address reviews

Author: matthias-springer

mlir/include/mlir/Conversion/LLVMCommon/Pattern.h

@@ -76,10 +76,8 @@ class ConvertToLLVMPattern : public ConversionPattern {
                              ConversionPatternRewriter &rewriter) const;
 
   /// Returns if the given memref type is convertible to LLVM and has an
-  /// identity layout map. If `verifyMemorySpace` is set to "false", the memory
-  /// space of the memref type is ignored.
-  bool isConvertibleAndHasIdentityMaps(MemRefType type,
-                                       bool verifyMemorySpace = true) const;
+  /// identity layout map.
+  bool isConvertibleAndHasIdentityMaps(MemRefType type) const;
 
   /// Returns the type of a pointer to an element of the memref.
   Type getElementPtrType(MemRefType type) const;

mlir/lib/Conversion/LLVMCommon/Pattern.cpp

@@ -98,13 +98,10 @@ Value ConvertToLLVMPattern::getStridedElementPtr(
 // Check if the MemRefType `type` is supported by the lowering. We currently
 // only support memrefs with identity maps.
 bool ConvertToLLVMPattern::isConvertibleAndHasIdentityMaps(
-    MemRefType type, bool verifyMemorySpace) const {
+    MemRefType type) const {
   if (!type.getLayout().isIdentity())
     return false;
-  // If the memory space should not be verified, just check the element type.
-  Type typeToVerify =
-      verifyMemorySpace ? static_cast<Type>(type) : type.getElementType();
-  return static_cast<bool>(typeConverter->convertType(typeToVerify));
+  return static_cast<bool>(typeConverter->convertType(type));
 }
 
 Type ConvertToLLVMPattern::getElementPtrType(MemRefType type) const {