Do not try to add got entry after emitting error diagnostic

kovdan01 · kovdan01 · commit 9d16e93c9131 · 2024-12-15T18:45:58.000+03:00
diff --git a/lld/ELF/Relocations.cpp b/lld/ELF/Relocations.cpp
@@ -1805,6 +1805,7 @@ void elf::postScanRelocations(Ctx &ctx) {
         diag << "both AUTH and non-AUTH GOT entries for '" << sym.getName()
              << "' requested, but only one type of GOT entry per symbol is "
                 "supported";
+        return;
       }
       if (flags & NEEDS_GOT_AUTH)
         addGotAuthEntry(ctx, sym);

Original file line number	Diff line number	Diff line change
`@@ -1805,6 +1805,7 @@ void elf::postScanRelocations(Ctx &ctx) {`
`1805`	`1805`	`diag << "both AUTH and non-AUTH GOT entries for '" << sym.getName()`
`1806`	`1806`	`<< "' requested, but only one type of GOT entry per symbol is "`
`1807`	`1807`	`"supported";`
	`1808`	`+ return;`
`1808`	`1809`	`}`
`1809`	`1810`	`if (flags & NEEDS_GOT_AUTH)`
`1810`	`1811`	`addGotAuthEntry(ctx, sym);`