Skip to content

Commit 90e97e7

Browse files
authored
[libc] Disable verbose logging messages on hermetic tests (#83954)
Summary: The other test locations only give these messages when we are in verbose logging mode. The average user does not care about which tests are not being built, and most platforms will have missing tests.
1 parent 67a7a5e commit 90e97e7

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

libc/cmake/modules/LLVMLibCTestRules.cmake

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -595,9 +595,11 @@ function(add_libc_hermetic_test test_name)
595595
get_object_files_for_test(
596596
link_object_files skipped_entrypoints_list ${fq_deps_list})
597597
if(skipped_entrypoints_list)
598-
set(msg "Skipping hermetic test ${fq_target_name} as it has missing deps: "
599-
"${skipped_entrypoints_list}.")
600-
message(STATUS ${msg})
598+
if(LIBC_CMAKE_VERBOSE_LOGGING)
599+
set(msg "Skipping hermetic test ${fq_target_name} as it has missing deps: "
600+
"${skipped_entrypoints_list}.")
601+
message(STATUS ${msg})
602+
endif()
601603
return()
602604
endif()
603605
list(REMOVE_DUPLICATES link_object_files)

0 commit comments

Comments
 (0)