Skip to content

Commit 74a512d

Browse files
authored
[mlir][vector] Populate sink patterns in apply_patterns.vector.reduction_to_contract (#104754)
This restores the functionality to before: 42944da This fixes a buildbot failure: https://lab.llvm.org/buildbot/#/builders/143/builds/1487
1 parent cde806b commit 74a512d

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

mlir/include/mlir/Dialect/Vector/TransformOps/VectorTransformOps.td

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ def ApplyFoldElementwiseToVectorPatternsOp : Op<Transform_Dialect,
410410
"apply_patterns.vector.elementwise_to_vector",
411411
[DeclareOpInterfaceMethods<PatternDescriptorOpInterface>]> {
412412
let description = [{
413-
Collect a set of patterns that fold elementwise op on vectors to the vector
413+
Collect a set of patterns that fold elementwise op on vectors to the vector
414414
dialect.
415415
}];
416416

@@ -426,8 +426,9 @@ def ApplyVectorReductionToContractPatternsOp : Op<Transform_Dialect,
426426
- CombineContractBroadcast
427427
- CombineContractABTranspose
428428
- CombineContractResultTranspose
429-
- ReorderCastOpsOnBroadcast
430429
- ReorderElementwiseOpsOnTranspose
430+
- ReorderElementwiseOpsOnBroadcast
431+
- ReorderCastOpsOnBroadcast
431432

432433
These patterns have the effect of rewriting a vector.multi_reduce into a
433434
vector.contract.

mlir/lib/Dialect/Vector/TransformOps/VectorTransformOps.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ void transform::ApplyFoldElementwiseToVectorPatternsOp::populatePatterns(
6767
void transform::ApplyVectorReductionToContractPatternsOp::populatePatterns(
6868
RewritePatternSet &patterns) {
6969
vector::populateVectorReductionToContractPatterns(patterns);
70+
vector::populateSinkVectorOpsPatterns(patterns);
7071
}
7172

7273
void transform::ApplyLowerCreateMaskPatternsOp::populatePatterns(

0 commit comments

Comments
 (0)