Consolidate MemoryProfile cl declaration into headers

Author: tstellar

llvm/include/llvm/Analysis/ProfileSummaryInfo.h

@@ -21,9 +21,12 @@
 #include "llvm/IR/PassManager.h"
 #include "llvm/IR/ProfileSummary.h"
 #include "llvm/Pass.h"
+#include "llvm/Support/CommandLine.h"
 #include <memory>
 #include <optional>
 
+LLVM_FUNC_ABI extern llvm::cl::opt<bool> ScalePartialSampleProfileWorkingSetSize;
+
 namespace llvm {
 class BasicBlock;
 class CallBase;

llvm/lib/Analysis/ModuleSummaryAnalysis.cpp

@@ -80,8 +80,6 @@ static cl::opt<std::string> ModuleSummaryDotFile(
     "module-summary-dot-file", cl::Hidden, cl::value_desc("filename"),
     cl::desc("File to emit dot graph of new summary into"));
 
-extern cl::opt<bool> ScalePartialSampleProfileWorkingSetSize;
-
 // Walk through the operands of a given User via worklist iteration and populate
 // the set of GlobalValue references encountered. Invoked either on an
 // Instruction or a GlobalVariable (which walks its initializer).

llvm/unittests/Analysis/ProfileSummaryInfoTest.cpp

@@ -24,8 +24,6 @@
 #include "llvm/Support/raw_ostream.h"
 #include "gtest/gtest.h"
 
-extern llvm::cl::opt<bool> ScalePartialSampleProfileWorkingSetSize;
-
 namespace llvm {
 namespace {