Skip to content

Commit 700f683

Browse files
committed
Revert "[clang] Don't inherit dllimport/dllexport to exclude_from_explicit_instantiation members during explicit instantiation (#65961)"
This uncovered a problem with virtual methods and exclude_from_explicit_instantiation, see #66909 Reverting until that's fixed. > This is a continuation of https://reviews.llvm.org/D155713 > > Fixes #40363 This reverts commit 84216d1.
1 parent 96b1784 commit 700f683

File tree

3 files changed

+0
-82
lines changed

3 files changed

+0
-82
lines changed

clang/lib/Sema/SemaDeclCXX.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6605,13 +6605,6 @@ void Sema::checkClassLevelDLLAttribute(CXXRecordDecl *Class) {
66056605
if (!VD && !MD)
66066606
continue;
66076607

6608-
if ((TSK == TSK_ExplicitInstantiationDeclaration ||
6609-
TSK == TSK_ExplicitInstantiationDefinition) &&
6610-
Member->hasAttr<ExcludeFromExplicitInstantiationAttr>()) {
6611-
// Skip members excluded from instantiation.
6612-
continue;
6613-
}
6614-
66156608
if (MD) {
66166609
// Don't process deleted methods.
66176610
if (MD->isDeleted())

clang/test/CodeGenCXX/attr-exclude_from_explicit_instantiation.dllimport.cpp

Lines changed: 0 additions & 48 deletions
This file was deleted.

clang/test/SemaCXX/attr-exclude_from_explicit_instantiation.dllimport.cpp

Lines changed: 0 additions & 27 deletions
This file was deleted.

0 commit comments

Comments
 (0)