[Transforms] Add more cos combinations to SimplifyLibCalls and InstCombineCalls

Add cos(fabs(x)) -> cos(x) and cos(copysign(x, y)) -> cos(x).

Author: AZero13

llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp

@@ -2488,11 +2488,13 @@ Instruction *InstCombinerImpl::visitCallInst(CallInst &CI) {
   }
   case Intrinsic::cos:
   case Intrinsic::amdgcn_cos: {
-    Value *X;
+    Value *X, *Sign;
     Value *Src = II->getArgOperand(0);
-    if (match(Src, m_FNeg(m_Value(X))) || match(Src, m_FAbs(m_Value(X)))) {
-      // cos(-x) -> cos(x)
-      // cos(fabs(x)) -> cos(x)
+    if (match(Src, m_FNeg(m_Value(X))) || match(Src, m_FAbs(m_Value(X))) ||
+        match(Src, m_CopySign(m_Value(X), m_Value(Sign)))) {
+      // cos(-x) --> cos(x)
+      // cos(fabs(x)) --> cos(x)
+      // cos(copysign(x, y)) --> cos(x)
       return replaceOperand(*II, 0, X);
     }
     break;

llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp

@@ -1933,12 +1933,18 @@ static Value *optimizeTrigReflections(CallInst *Call, LibFunc Func,
     break;
   case LibFunc_cos:
   case LibFunc_cosf:
-  case LibFunc_cosl:
-    // cos(-X) --> cos(X)
-    if (match(Call->getArgOperand(0), m_FNeg(m_Value(X))))
+  case LibFunc_cosl: {
+    // cos(-x) --> cos(x)
+    // cos(fabs(x)) --> cos(x)
+    // cos(copysign(x, y)) --> cos(x)
+    Value *Sign;
+    if (match(Call->getArgOperand(0), m_FNeg(m_Value(X))) ||
+        match(Call->getArgOperand(0), m_FAbs(m_Value(X))) ||
+        match(Call->getArgOperand(0), m_CopySign(m_Value(X), m_Value(Sign))))
       return copyFlags(*Call,
                        B.CreateCall(Call->getCalledFunction(), X, "cos"));
     break;
+  }
   default:
     break;
   }

llvm/test/Transforms/InstCombine/cos-1.ll

@@ -112,9 +112,8 @@ define float @cosf_unary_negated_arg_FMF(float %x) {
 
 define double @cos_unary_fabs_arg(double %x) {
 ; ANY-LABEL: @cos_unary_fabs_arg(
-; ANY-NEXT:    [[FABS:%.*]] = tail call double @llvm.fabs.f64(double [[X:%.*]])
-; ANY-NEXT:    [[R:%.*]] = call double @cos(double [[FABS]])
-; ANY-NEXT:    ret double [[R]]
+; ANY-NEXT:    [[COS:%.*]] = call double @cos(double [[X:%.*]])
+; ANY-NEXT:    ret double [[COS]]
 ;
   %fabs = tail call double @llvm.fabs.f64(double %x)
   %r = call double @cos(double %fabs)
@@ -123,9 +122,8 @@ define double @cos_unary_fabs_arg(double %x) {
 
 define float @cosf_unary_fabs_arg(float %x) {
 ; ANY-LABEL: @cosf_unary_fabs_arg(
-; ANY-NEXT:    [[FABS:%.*]] = tail call float @llvm.fabs.f32(float [[X:%.*]])
-; ANY-NEXT:    [[R:%.*]] = call float @cosf(float [[FABS]])
-; ANY-NEXT:    ret float [[R]]
+; ANY-NEXT:    [[COS:%.*]] = call float @cosf(float [[X:%.*]])
+; ANY-NEXT:    ret float [[COS]]
 ;
   %fabs = tail call float @llvm.fabs.f32(float %x)
   %r = call float @cosf(float %fabs)
@@ -134,9 +132,8 @@ define float @cosf_unary_fabs_arg(float %x) {
 
 define float @cosf_unary_fabs_arg_FMF(float %x) {
 ; ANY-LABEL: @cosf_unary_fabs_arg_FMF(
-; ANY-NEXT:    [[FABS:%.*]] = tail call float @llvm.fabs.f32(float [[X:%.*]])
-; ANY-NEXT:    [[R:%.*]] = call reassoc nnan float @cosf(float [[FABS]])
-; ANY-NEXT:    ret float [[R]]
+; ANY-NEXT:    [[COS:%.*]] = call reassoc nnan float @cosf(float [[X:%.*]])
+; ANY-NEXT:    ret float [[COS]]
 ;
   %fabs = tail call float @llvm.fabs.f32(float %x)
   %r = call nnan reassoc float @cosf(float %fabs)
@@ -147,9 +144,8 @@ define float @cosf_unary_fabs_arg_FMF(float %x) {
 
 define double @cos_copysign_arg(double %x, double %y) {
 ; ANY-LABEL: @cos_copysign_arg(
-; ANY-NEXT:    [[COPYSIGN:%.*]] = tail call double @llvm.copysign.f64(double [[X:%.*]], double [[Y:%.*]])
-; ANY-NEXT:    [[R:%.*]] = call double @cos(double [[COPYSIGN]])
-; ANY-NEXT:    ret double [[R]]
+; ANY-NEXT:    [[COS:%.*]] = call double @cos(double [[X:%.*]])
+; ANY-NEXT:    ret double [[COS]]
 ;
   %copysign = tail call double @llvm.copysign(double %x, double %y)
   %r = call double @cos(double %copysign)
@@ -159,9 +155,8 @@ define double @cos_copysign_arg(double %x, double %y) {
 
 define float @cosf_unary_copysign_arg(float %x) {
 ; ANY-LABEL: @cosf_unary_copysign_arg(
-; ANY-NEXT:    [[COPYSIGN:%.*]] = call float @llvm.fabs.f32(float [[X:%.*]])
-; ANY-NEXT:    [[R:%.*]] = call float @cosf(float [[COPYSIGN]])
-; ANY-NEXT:    ret float [[R]]
+; ANY-NEXT:    [[COS:%.*]] = call float @cosf(float [[X:%.*]])
+; ANY-NEXT:    ret float [[COS]]
 ;
   %copysign = tail call float @llvm.copysign.f32(float %x, float 1.0)
   %r = call float @cosf(float %copysign)
@@ -170,9 +165,8 @@ define float @cosf_unary_copysign_arg(float %x) {
 
 define float @cosf_copysign_arg_FMF(float %x, float %y) {
 ; ANY-LABEL: @cosf_copysign_arg_FMF(
-; ANY-NEXT:    [[COPYSIGN:%.*]] = tail call float @llvm.copysign.f32(float [[X:%.*]], float [[Y:%.*]])
-; ANY-NEXT:    [[R:%.*]] = call reassoc nnan float @cosf(float [[COPYSIGN]])
-; ANY-NEXT:    ret float [[R]]
+; ANY-NEXT:    [[COS:%.*]] = call reassoc nnan float @cosf(float [[X:%.*]])
+; ANY-NEXT:    ret float [[COS]]
 ;
   %copysign = tail call float @llvm.copysign.f32(float %x, float %y)
   %r = call nnan reassoc float @cosf(float %copysign)